[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 114219: Do not encode QString to QByteArray and cast it
From:       "Yichao Yu" <yyc1992 () gmail ! com>
Date:       2013-11-30 4:38:52
Message-ID: 20131130043852.26935.64853 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114219/
-----------------------------------------------------------

(Updated Nov. 29, 2013, 11:38 p.m.)


Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo Pereira Da \
Costa.


Changes
-------

Tested myself.


Bugs: 327919
    http://bugs.kde.org/show_bug.cgi?id=327919


Repository: kde-workspace


Description
-------

list.join already returns a QString and there is no need to encode it and cast back \
to QString again....

P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, \
frameworks for kdelibs?) How should I submit review request? Should I add both in \
branch or submit two review request? (But often the patch cannot apply directly due \
to context or file path changes).


Diffs
-----

  kcontrol/krdb/krdb.cpp 92d84e9 

Diff: http://git.reviewboard.kde.org/r/114219/diff/


Testing (updated)
-------

Compiles.
Fixes the problem here.


Thanks,

Yichao Yu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114219/">http://git.reviewboard.kde.org/r/114219/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace, David Faure, Martin Gräßlin, and Hugo \
Pereira Da Costa.</div> <div>By Yichao Yu.</div>


<p style="color: grey;"><i>Updated Nov. 29, 2013, 11:38 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested myself. </pre>
  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=327919">327919</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">list.join already returns a QString and there is no need to encode it \
and cast back to QString again....

P.S. for a patch that applies to both KDE4 and KF5(master for kde-workspace, \
frameworks for kdelibs?) How should I submit review request? Should I add both in \
branch or submit two review request? (But often the patch cannot apply directly due \
to context or file path changes).</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles. Fixes the problem here.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/krdb/krdb.cpp <span style="color: grey">(92d84e9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114219/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic