[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113985: Remove no-ops in KCategorizedView
From: "Yichao Yu" <yyc1992 () gmail ! com>
Date: 2013-11-27 2:19:22
Message-ID: 20131127021922.16923.69721 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 25, 2013, 1:35 p.m., David Faure wrote:
> > Ship It!
Thanks for the review. However, I don't have a git account yet and I cannot find \
others to push it for me this time. Could you please push it for me?
- Yichao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113985/#review44451
-----------------------------------------------------------
On Nov. 21, 2013, 8:34 p.m., Yichao Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113985/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 8:34 p.m.)
>
>
> Review request for kdelibs, David Faure, Rafael Fernández López, and Michael \
> Pyne.
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Remove operations on temporary returned objects.
> These are no-ops and are not needed since they are already done in visualRect.
>
>
> Diffs
> -----
>
> kdeui/itemviews/kcategorizedview.cpp 010bcbc
>
> Diff: http://git.reviewboard.kde.org/r/113985/diff/
>
>
> Testing
> -------
>
> It compiles.
>
> (It compiles when just adding const to the QRect, proving they are indeed no-op's).
>
>
> Thanks,
>
> Yichao Yu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113985/">http://git.reviewboard.kde.org/r/113985/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 25th, 2013, 1:35 p.m. EST, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the review. \
However, I don't have a git account yet and I cannot find others to push it for \
me this time. Could you please push it for me? </pre>
<br />
<p>- Yichao</p>
<br />
<p>On November 21st, 2013, 8:34 p.m. EST, Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, David Faure, Rafael Fernández López, and Michael \
Pyne.</div> <div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2013, 8:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove operations on temporary returned objects. These are no-ops and \
are not needed since they are already done in visualRect. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles.
(It compiles when just adding const to the QRect, proving they are indeed \
no-op's). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/itemviews/kcategorizedview.cpp <span style="color: \
grey">(010bcbc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113985/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic