[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 114017: Possibly fix crash with horizontal wheel on tabs
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2013-11-26 11:22:35
Message-ID: 20131126112235.20017.47284 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114017/
-----------------------------------------------------------

(Updated Nov. 26, 2013, 11:22 a.m.)


Review request for kdelibs.


Changes
-------

Basic testing.


Bugs: 314082
    http://bugs.kde.org/show_bug.cgi?id=314082


Repository: kdelibs


Description
-------

Details at bug 314082.

From how I understand the problem, we should not sent the fake event for horizontal scrolling, \
because it is not handled by the tabbar code. Someone please confirm it fixes the problem.


Diffs
-----

  kdeui/widgets/ktabwidget.cpp 49dc293 

Diff: http://git.reviewboard.kde.org/r/114017/diff/


Testing (updated)
-------

Fixes the crash, according to a tester.


Thanks,

Christoph Feck


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114017/">http://git.reviewboard.kde.org/r/114017/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Christoph Feck.</div>


<p style="color: grey;"><i>Updated Nov. 26, 2013, 11:22 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic testing.</pre>  \
</td>  </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=314082">314082</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Details at bug \
314082.

From how I understand the problem, we should not sent the fake event for horizontal scrolling, \
because it is not handled by the tabbar code. Someone please confirm it fixes the \
problem.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the crash, \
according to a tester.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/widgets/ktabwidget.cpp <span style="color: grey">(49dc293)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114017/diff/" style="margin-left: 3em;">View \
Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic