--===============2593458009445329587== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113985/#review44451 ----------------------------------------------------------- Ship it! Ship It! - David Faure On Nov. 22, 2013, 1:34 a.m., Yichao Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113985/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 1:34 a.m.) > > > Review request for kdelibs, David Faure, Rafael Fernández López, and Michael Pyne. > > > Repository: kdelibs > > > Description > ------- > > Remove operations on temporary returned objects. > These are no-ops and are not needed since they are already done in visualRect. > > > Diffs > ----- > > kdeui/itemviews/kcategorizedview.cpp 010bcbc > > Diff: http://git.reviewboard.kde.org/r/113985/diff/ > > > Testing > ------- > > It compiles. > > (It compiles when just adding const to the QRect, proving they are indeed no-op's). > > > Thanks, > > Yichao Yu > > --===============2593458009445329587== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113985/

Ship it!

Ship It!

- David Faure


On November 22nd, 2013, 1:34 a.m. UTC, Yichao Yu wrote:

Review request for kdelibs, David Faure, Rafael Fernández López, and Michael Pyne.
By Yichao Yu.

Updated Nov. 22, 2013, 1:34 a.m.

Repository: kdelibs

Description 

Remove operations on temporary returned objects.
These are no-ops and are not needed since they are already done in visualRect.

Testing 

It compiles.

(It compiles when just adding const to the QRect, proving they are indeed no-op's).

Diffs

  • kdeui/itemviews/kcategorizedview.cpp (010bcbc)

View Diff
--===============2593458009445329587==--