[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type
From: "Andrea Iacovitti" <aiacovitti () libero ! it>
Date: 2013-11-25 13:53:23
Message-ID: 20131125135323.27408.53870 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105/
-----------------------------------------------------------
Review request for KDE Base Apps and Dawit Alemayehu.
Repository: kde-baseapps
Description
-------
In case of 'system proxy' proxyType, NoProxyFor config key holds the name of the env \
variable (e.g. no_proxy) and not its value. Because of this \
KProtocolManager::noProxyFor() can not be used to get NoProxyFor config setting in \
KProxyDialog::load(), as it returns the resolved value of the environment variable \
and not its name: i added helper method KSaveIOConfig::noProxyFor() to read that \
value directly from config file. Also make sure to uncheck showEnvValueCheckBox \
before filling proxy edit fields with environment variable names in \
KProxyDialog::on_autoDetectButton_clicked().
Diffs
-----
konqueror/settings/kio/kproxydlg.cpp e80afeb
konqueror/settings/kio/ksaveioconfig.h 2318198
konqueror/settings/kio/ksaveioconfig.cpp c822f7b
Diff: http://git.reviewboard.kde.org/r/114105/diff/
Testing
-------
various...
Thanks,
Andrea Iacovitti
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114105/">http://git.reviewboard.kde.org/r/114105/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and Dawit Alemayehu.</div>
<div>By Andrea Iacovitti.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In case of 'system proxy' proxyType, NoProxyFor config key holds \
the name of the env variable (e.g. no_proxy) and not its value. Because of this \
KProtocolManager::noProxyFor() can not be used to get NoProxyFor config setting in \
KProxyDialog::load(), as it returns the resolved value of the environment variable \
and not its name: i added helper method KSaveIOConfig::noProxyFor() to read that \
value directly from config file. Also make sure to uncheck showEnvValueCheckBox \
before filling proxy edit fields with environment variable names in \
KProxyDialog::on_autoDetectButton_clicked().</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">various...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/settings/kio/kproxydlg.cpp <span style="color: \
grey">(e80afeb)</span></li>
<li>konqueror/settings/kio/ksaveioconfig.h <span style="color: \
grey">(2318198)</span></li>
<li>konqueror/settings/kio/ksaveioconfig.cpp <span style="color: \
grey">(c822f7b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114105/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic