'Re: Review Request 112982: copy[To|From]File support for kio_smb'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 112982: copy[To|From]File support for kio_smb
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2013-11-25 0:34:11
Message-ID: 20131125003411.22011.35787 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112982/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 12:34 a.m.)


Review request for KDE Runtime and David Faure.


Changes
-------

Use #ifdef for permission conversion code present only in KDE 4.11.80 or higher. That \
way I do not have to change the required kdelibs version to compile kde-runtime.


Bugs: 176271 and 291835
    http://bugs.kde.org/show_bug.cgi?id=176271
    http://bugs.kde.org/show_bug.cgi?id=291835


Repository: kde-runtime


Description
-------

The attach patch adds support for the following to kio_smb:

- copyToFile/copyFromFile optimizations so uploading and downloading files from \
                window shares is faster so long as one end is a local file.
- partial download resumption as part of the copyToFile implementation.
- preservation of modified file timstamp. Again as part of the copyToFile \
implementation.


Diffs (updated)
-----

  kioslave/smb/kio_smb.h 55efb44 
  kioslave/smb/kio_smb_dir.cpp 1f013df 
  kioslave/smb/kio_smb_internal.h b895b81 
  kioslave/smb/kio_smb_internal.cpp 3c35583 
  kioslave/smb/smb.protocol 654bcfb 

Diff: http://git.reviewboard.kde.org/r/112982/diff/


Testing
-------

- Copied files to and from smb share.
- Resumed interrupted file copy to and from smb share.


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112982/">http://git.reviewboard.kde.org/r/112982/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime and David Faure.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated Nov. 25, 2013, 12:34 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use #ifdef for permission conversion code present only in KDE 4.11.80 or \
higher. That way I do not have to change the required kdelibs version to compile \
kde-runtime.</pre>  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=176271">176271</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=291835">291835</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attach patch adds support for the following to kio_smb:

- copyToFile/copyFromFile optimizations so uploading and downloading files from \
                window shares is faster so long as one end is a local file.
- partial download resumption as part of the copyToFile implementation.
- preservation of modified file timstamp. Again as part of the copyToFile \
implementation. </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- Copied files to and from smb share.
- Resumed interrupted file copy to and from smb share.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/smb/kio_smb.h <span style="color: grey">(55efb44)</span></li>

 <li>kioslave/smb/kio_smb_dir.cpp <span style="color: grey">(1f013df)</span></li>

 <li>kioslave/smb/kio_smb_internal.h <span style="color: grey">(b895b81)</span></li>

 <li>kioslave/smb/kio_smb_internal.cpp <span style="color: \
grey">(3c35583)</span></li>

 <li>kioslave/smb/smb.protocol <span style="color: grey">(654bcfb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112982/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic