[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113853: port kcm icons to KF5
From: "Jonathan Riddell" <jr () jriddell ! org>
Date: 2013-11-14 16:33:47
Message-ID: 20131114163347.13254.45947 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 14, 2013, 2:55 p.m., Sebastian Kügler wrote:
> > Nice.
> >
> > The QFormLayout doesn't need to be replaced, see the comment inline.
> >
> > Did you test if switching icons works with this? Are changes being picked up at \
> > run-time?
diff updated with points mentioned
switching icon themes and effects works yes but the changes do not seem to be picked \
up at run-time also the KColorButton widgets don't seem to work, you select a colour \
but the widget doesn't show the selection
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113853/#review43666
-----------------------------------------------------------
On Nov. 14, 2013, 4:26 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113853/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 4:26 p.m.)
>
>
> Review request for KDE Runtime and Sebastian Kügler.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> port kcm icons to Qt 5 and KF 5
>
>
> Diffs
> -----
>
> kcontrol/icons/iconthemes.h 7352c21
> kcontrol/icons/iconthemes.cpp 9899686
> kcontrol/icons/main.h 066080d
> kcontrol/icons/main.cpp c98d78a
> kcontrol/icons/tests/CMakeLists.txt 2199068
> kcontrol/icons/tests/testicons.cpp eae44b1
> kcontrol/icons/CMakeLists.txt b16a52b
> kcontrol/icons/icons.cpp 3813651
> kcontrol/icons/icons.desktop d594788
> kcontrol/icons/icons.h 1217c99
> kcontrol/CMakeLists.txt 6e6d593
>
> Diff: http://git.reviewboard.kde.org/r/113853/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113853/">http://git.reviewboard.kde.org/r/113853/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 14th, 2013, 2:55 p.m. UTC, \
<b>Sebastian Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Nice.
The QFormLayout doesn't need to be replaced, see the comment inline.
Did you test if switching icons works with this? Are changes being picked up at \
run-time?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">diff updated with points \
mentioned switching icon themes and effects works yes but the changes do not seem to \
be picked up at run-time also the KColorButton widgets don't seem to work, you \
select a colour but the widget doesn't show the selection </pre>
<br />
<p>- Jonathan</p>
<br />
<p>On November 14th, 2013, 4:26 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Sebastian Kügler.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2013, 4:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">port kcm icons to Qt 5 and KF 5</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/icons/iconthemes.h <span style="color: grey">(7352c21)</span></li>
<li>kcontrol/icons/iconthemes.cpp <span style="color: grey">(9899686)</span></li>
<li>kcontrol/icons/main.h <span style="color: grey">(066080d)</span></li>
<li>kcontrol/icons/main.cpp <span style="color: grey">(c98d78a)</span></li>
<li>kcontrol/icons/tests/CMakeLists.txt <span style="color: \
grey">(2199068)</span></li>
<li>kcontrol/icons/tests/testicons.cpp <span style="color: \
grey">(eae44b1)</span></li>
<li>kcontrol/icons/CMakeLists.txt <span style="color: grey">(b16a52b)</span></li>
<li>kcontrol/icons/icons.cpp <span style="color: grey">(3813651)</span></li>
<li>kcontrol/icons/icons.desktop <span style="color: grey">(d594788)</span></li>
<li>kcontrol/icons/icons.h <span style="color: grey">(1217c99)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(6e6d593)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113853/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic