[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2013-11-11 11:31:54
Message-ID: 20131111113154.31527.32380 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113779/
-----------------------------------------------------------
(Updated Nov. 11, 2013, 11:31 a.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace and David Stephen Hubner.
Bugs: 327382
http://bugs.kde.org/show_bug.cgi?id=327382
Repository: kde-workspace
Description
-------
ReadPipe() doesn't return 0 as expected in the case that the command is not found. \
but the length of sh's output which is "command not found" in this case. This is \
because popen() does not fail if the command is not found, because it _can_ run "sh". \
(according to the man page, popen calls "/bin/sh -c command") To fix this, ReadPipe() \
should check the return code of the call to pclose() (see "man pclose"), and return 0 \
if this is not equal to 0.
Diffs
-----
kinfocenter/Modules/opengl/opengl.cpp 7df2b17
Diff: http://git.reviewboard.kde.org/r/113779/diff/
Testing
-------
Run KInfocenter on openSUSE, where lspci is in /sbin and that is not in the user's \
path. Without this patch, 3D Accelerator will be shown as "unknown" (because lspci \
cannot be run, with this patch it works as intended. I also tried with lspci in \
/usr/bin/ (i.e. in the path) and completely removed, worked as expected (correct \
information in the former case, "unknown" in the latter).
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113779/">http://git.reviewboard.kde.org/r/113779/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and David Stephen Hubner.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2013, 11:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327382">327382</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ReadPipe() doesn't return 0 as expected in the case that the command \
is not found. but the length of sh's output which is "command not \
found" in this case. This is because popen() does not fail if the command is not \
found, because it _can_ run "sh". (according to the man page, popen calls \
"/bin/sh -c command") To fix this, ReadPipe() should check the return code \
of the call to pclose() (see "man pclose"), and return 0 if this is not \
equal to 0.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run KInfocenter on openSUSE, where lspci is in /sbin and that is not in \
the user's path. Without this patch, 3D Accelerator will be shown as \
"unknown" (because lspci cannot be run, with this patch it works as \
intended. I also tried with lspci in /usr/bin/ (i.e. in the path) and completely \
removed, worked as expected (correct information in the former case, \
"unknown" in the latter).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kinfocenter/Modules/opengl/opengl.cpp <span style="color: \
grey">(7df2b17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113779/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic