From kde-core-devel Sun Nov 10 18:03:54 2013 From: "Denis Kuplyakov" Date: Sun, 10 Nov 2013 18:03:54 +0000 To: kde-core-devel Subject: Re: Review Request 112880: Added KColorSchemeToken class. Message-Id: <20131110180354.31062.90811 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138410897400618 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2254584047167689528==" --===============2254584047167689528== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? Yes I will finish it, when have time. There are many pre-exams in university. - Denis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 ----------------------------------------------------------- On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112880/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2013, 7:24 p.m.) > > > Review request for KDE Frameworks and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > It is wrapper to access KColorScheme's methods from QML code. > Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code. > > As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme. > > More info: > * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists * > > > Diffs > ----- > > kdeui/CMakeLists.txt b439e04 > includes/CMakeLists.txt cdf0143 > includes/KColorSchemeToken PRE-CREATION > kdeui/colors/kcolorscheme.h 17570fd > kdeui/colors/kcolorscheme.cpp a6650ac > kdeui/colors/kcolorschemetoken.h PRE-CREATION > kdeui/colors/kcolorschemetoken.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112880/diff/ > > > Testing > ------- > > I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. > > > Thanks, > > Denis Kuplyakov > > --===============2254584047167689528== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/

On October 21st, 2013, 11:22 a.m. UTC, Kevin Ottens wrote:

To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative.

On November 10th, 2013, 3:44 p.m. UTC, Kevin Ottens wrote:

Any chance for an update?
Yes I will finish it, when have time. There are many pre-exams in university.

- Denis


On October 6th, 2013, 7:24 p.m. UTC, Denis Kuplyakov wrote:

Review request for KDE Frameworks and kdelibs.
By Denis Kuplyakov.

Updated Oct. 6, 2013, 7:24 p.m.

Repository: kdelibs

Description 

It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.

As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.

More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *

Testing 

I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.

Diffs

  • kdeui/CMakeLists.txt (b439e04)
  • includes/CMakeLists.txt (cdf0143)
  • includes/KColorSchemeToken (PRE-CREATION)
  • kdeui/colors/kcolorscheme.h (17570fd)
  • kdeui/colors/kcolorscheme.cpp (a6650ac)
  • kdeui/colors/kcolorschemetoken.h (PRE-CREATION)
  • kdeui/colors/kcolorschemetoken.cpp (PRE-CREATION)

View Diff
--===============2254584047167689528==--