This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/

On October 21st, 2013, 11:22 a.m. UTC, Kevin Ottens wrote:

To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative.
Any chance for an update?

- Kevin


On October 6th, 2013, 7:24 p.m. UTC, Denis Kuplyakov wrote:

Review request for KDE Frameworks and kdelibs.
By Denis Kuplyakov.

Updated Oct. 6, 2013, 7:24 p.m.

Repository: kdelibs

Description

It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.

As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.

More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *

Testing

I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.

Diffs

  • kdeui/CMakeLists.txt (b439e04)
  • includes/CMakeLists.txt (cdf0143)
  • includes/KColorSchemeToken (PRE-CREATION)
  • kdeui/colors/kcolorscheme.h (17570fd)
  • kdeui/colors/kcolorscheme.cpp (a6650ac)
  • kdeui/colors/kcolorschemetoken.h (PRE-CREATION)
  • kdeui/colors/kcolorschemetoken.cpp (PRE-CREATION)

View Diff