[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be
From:       Rolf Eike Beer <kde () opensource ! sf-tec ! de>
Date:       2013-11-10 8:11:25
Message-ID: 23883771.EPg94Fv4BY () caliban ! sf-tec ! de
[Download RAW message or body]


> ReadPipe() doesn't return 0 as expected in the case that the command is not
> found. but the length of sh's output which is "command not found" in this
> case. This is because popen() does not fail if the command is not found,
> because it _can_ run "sh". (according to the man page, popen calls "/bin/sh
> -c command") To fix this, ReadPipe() should check the return code of the
> call to pclose() (see "man pclose"), and return 0 if this is not equal to
> 0.

Can't this be ported to simply use QProcess instead?

Eike
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]