[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, an
From: "Ralf Habacker" <ralf.habacker () freenet ! de>
Date: 2013-11-08 21:52:48
Message-ID: 20131108215248.22049.19572 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 8, 2013, 5:31 p.m., Andrius da Costa Ribas wrote:
> > ping? may I ship it?
I can confirm that this patch works on linux opensuse 12.2 with kde 4.11. Exe and \
windows thumbnail are visible in dolphin with installed icoutils package and enabled \
preview.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112009/#review43272
-----------------------------------------------------------
On Aug. 17, 2013, 3:43 p.m., Andrius da Costa Ribas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112009/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 3:43 p.m.)
>
>
> Review request for KDE Runtime, kdewin and Pali Rohár.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> This patch intends to enable Windows exe/dll thumbnailing by using winapi. It \
> derives from the unsubmitted patch from Pali Rohár from \
> https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few \
> adjustments on the original patch, split that patch into a common part and a \
> icoutils-specific part, and then created the winapi-based part to replace the \
> icoutils one on Windows (porting icoutils to windows wasn't going to be easy).
>
> Diffs
> -----
>
> kioslave/thumbnail/CMakeLists.txt b81339b
> kioslave/thumbnail/icoutils.h 6468bc1
> kioslave/thumbnail/icoutils.cpp 31db85d
> kioslave/thumbnail/icoutils_common.cpp PRE-CREATION
> kioslave/thumbnail/icoutils_win.cpp PRE-CREATION
> kioslave/thumbnail/icoutils_wrestool.cpp PRE-CREATION
> kioslave/thumbnail/windowsexecreator.h a407982
> kioslave/thumbnail/windowsexecreator.cpp 9e24aee
> kioslave/thumbnail/windowsexethumbnail.desktop f10efef
> kioslave/thumbnail/windowsimagecreator.h 0b68cc6
> kioslave/thumbnail/windowsimagecreator.cpp 08b063d
>
> Diff: http://git.reviewboard.kde.org/r/112009/diff/
>
>
> Testing
> -------
>
> Tested on a Windows 7 64-bit machine, with intel compiler (32-bit).
> Tested using ico files and both 32-bit and 64-bit executables and dlls, including \
> jumbo-size icons. I've used QLibrary for all winapi functions in order to avoid \
> issues with MinGW compiler, but I don't have a MinGW setup to check.
> Not tested on *nix, but the original patch was not changed except for iterating \
> order in the common part and namespacing.
>
> File Attachments
> ----------------
>
> screenshot
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png
>
>
> Thanks,
>
> Andrius da Costa Ribas
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112009/">http://git.reviewboard.kde.org/r/112009/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 8th, 2013, 5:31 p.m. CET, <b>Andrius \
da Costa Ribas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ping? may I ship it?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can confirm that this \
patch works on linux opensuse 12.2 with kde 4.11. Exe and windows thumbnail are \
visible in dolphin with installed icoutils package and enabled preview. </pre>
<br />
<p>- Ralf</p>
<br />
<p>On August 17th, 2013, 3:43 p.m. CEST, Andrius da Costa Ribas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, kdewin and Pali Rohár.</div>
<div>By Andrius da Costa Ribas.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 3:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch intends to enable Windows exe/dll thumbnailing by using \
winapi. It derives from the unsubmitted patch from Pali Rohár from \
https://svn.reviewboard.kde.org/r/5156/ as a starting point. I've made a few \
adjustments on the original patch, split that patch into a common part and a \
icoutils-specific part, and then created the winapi-based part to replace the \
icoutils one on Windows (porting icoutils to windows wasn't going to be \
easy).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on a Windows 7 64-bit machine, with intel compiler (32-bit). \
Tested using ico files and both 32-bit and 64-bit executables and dlls, including \
jumbo-size icons. I've used QLibrary for all winapi functions in order to avoid \
issues with MinGW compiler, but I don't have a MinGW setup to check.
Not tested on *nix, but the original patch was not changed except for iterating order \
in the common part and namespacing. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/thumbnail/CMakeLists.txt <span style="color: \
grey">(b81339b)</span></li>
<li>kioslave/thumbnail/icoutils.h <span style="color: grey">(6468bc1)</span></li>
<li>kioslave/thumbnail/icoutils.cpp <span style="color: grey">(31db85d)</span></li>
<li>kioslave/thumbnail/icoutils_common.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/thumbnail/icoutils_win.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/thumbnail/icoutils_wrestool.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kioslave/thumbnail/windowsexecreator.h <span style="color: \
grey">(a407982)</span></li>
<li>kioslave/thumbnail/windowsexecreator.cpp <span style="color: \
grey">(9e24aee)</span></li>
<li>kioslave/thumbnail/windowsexethumbnail.desktop <span style="color: \
grey">(f10efef)</span></li>
<li>kioslave/thumbnail/windowsimagecreator.h <span style="color: \
grey">(0b68cc6)</span></li>
<li>kioslave/thumbnail/windowsimagecreator.cpp <span style="color: \
grey">(08b063d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112009/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/11/Icons.png">screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic