[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113413: Improved Keyboard Layout Preview
From: "shivam makkar" <amourphious1992 () gmail ! com>
Date: 2013-11-05 20:22:06
Message-ID: 20131105202206.19036.73735 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113413/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 8:22 p.m.)
Review request for KDE Runtime, kde-workspace and Andriy Rysin.
Changes
-------
Fixed the function key display string.
Repository: kde-workspace
Description
-------
Improved keyboard layout preview
added geometry feature, multi-level keys (>4) and parsed geometry file using Boost \
c++ libraries and tool tip showing symbol names. my GSoC-13 project !
Diffs (updated)
-----
kcontrol/keyboard/preview/kbpreviewframe.cpp 40359f9
kcontrol/keyboard/preview/keyboardpainter.cpp 0427102
Diff: http://git.reviewboard.kde.org/r/113413/diff/
Testing
-------
File Attachments (updated)
----------------
English layout default geometry
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/57ce3e15-26a9-46e2-ad5d-6073e04a5489__snapshot16.jpg
german neo 2 layout default geometry
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/231ded09-9f22-44f5-aafe-6759c683b552__snapshot17.jpg
ukranian layout microsoft natural geometry
http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/8dca14f2-2d00-46d1-95a1-f7eca0ff5831__snapshot18.jpg
Thanks,
shivam makkar
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113413/">http://git.reviewboard.kde.org/r/113413/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, kde-workspace and Andriy Rysin.</div>
<div>By shivam makkar.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2013, 8:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed the function key display string.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Improved keyboard layout preview added geometry feature, multi-level \
keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing \
symbol names. my GSoC-13 project !</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keyboard/preview/kbpreviewframe.cpp <span style="color: \
grey">(40359f9)</span></li>
<li>kcontrol/keyboard/preview/keyboardpainter.cpp <span style="color: \
grey">(0427102)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113413/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/57ce3e15-26a9-46e2-ad5d-6073e04a5489__snapshot16.jpg">English \
layout default geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/231ded09-9f22-44f5-aafe-6759c683b552__snapshot17.jpg">german \
neo 2 layout default geometry</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/8dca14f2-2d00-46d1-95a1-f7eca0ff5831__snapshot18.jpg">ukranian \
layout microsoft natural geometry</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic