[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 113504: Fix krunner calculator letter check
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2013-10-30 0:25:53
Message-ID: 20131030002553.18141.49910 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113504/
-----------------------------------------------------------
Review request for kde-workspace and Plasma.
Bugs: 326059
http://bugs.kde.org/show_bug.cgi?id=326059
Repository: kde-workspace
Description
-------
The calculator runner now supports the syntax without the '=', so you can simply type \
in '3+5' and have the result. An additional commit added a letter check, so that it \
will not try to compute with normal text input, but this broke any calculations with \
any functions, such as '=6*asin 0.5' etc.
This commit removes the letter check in case the user had explicitly typed the '=', \
restoring 4.10 behavior. If I understand the letter check correctly, it is very hard \
to support functions in the case the user had omitted the '='
Diffs
-----
plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301
Diff: http://git.reviewboard.kde.org/r/113504/diff/
Testing
-------
Thanks,
Christoph Feck
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113504/">http://git.reviewboard.kde.org/r/113504/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Christoph Feck.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326059">326059</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The calculator runner now supports the syntax without the '=', \
so you can simply type in '3+5' and have the result. An additional commit \
added a letter check, so that it will not try to compute with normal text input, but \
this broke any calculations with any functions, such as '=6*asin 0.5' etc.
This commit removes the letter check in case the user had explicitly typed the \
'=', restoring 4.10 behavior. If I understand the letter check correctly, it \
is very hard to support functions in the case the user had omitted the \
'='</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/calculator/calculatorrunner.cpp <span style="color: \
grey">(0d52301)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113504/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic