[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113493: Fix entering kcm_kdm resets settings of current session
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2013-10-29 8:01:55
Message-ID: 20131029080155.29815.11714 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113493/#review42574
-----------------------------------------------------------
Ship it!
pushed to 4.11. the git history suggests that it will be forward-merged to master at \
some point...
- Oswald Buddenhagen
On Oct. 28, 2013, 11:14 p.m., Luc Menut wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113493/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 11:14 p.m.)
>
>
> Review request for kde-workspace and Oswald Buddenhagen.
>
>
> Bugs: 254430
> http://bugs.kde.org/show_bug.cgi?id=254430
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Entering the Login Screen module from systemsettings adds system-wide values (from \
> system kdeglobals) to user values in ~/.kde/share/config/kdeglobals. Thus, lot of \
> user settings are lost (font, style, colors, default Web Browser, ...).
> Opening backgroundrc (line 306) with KConfig::SimpleConfig OpenFlag (like for kdmrc \
> at line 285) fixes this issue. This fix was proposed by Pulfer in bugreport \
> 254430#c16.
> regards,
> Luc Menut - Mageia
>
> PS: I don't have write access to kde git, so could you commit the change if the \
> patch looks fine. Thanks.
>
> Diffs
> -----
>
> kdm/kcm/main.cpp 8560c89
>
> Diff: http://git.reviewboard.kde.org/r/113493/diff/
>
>
> Testing
> -------
>
> tested with KDE 4.11.2 (Mageia Cauldron)
>
>
> Thanks,
>
> Luc Menut
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113493/">http://git.reviewboard.kde.org/r/113493/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pushed to 4.11. the git \
history suggests that it will be forward-merged to master at some point...</pre> <br \
/>
<p>- Oswald Buddenhagen</p>
<br />
<p>On October 28th, 2013, 11:14 p.m. UTC, Luc Menut wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Oswald Buddenhagen.</div>
<div>By Luc Menut.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 11:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=254430">254430</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Entering the Login Screen module from systemsettings adds system-wide \
values (from system kdeglobals) to user values in ~/.kde/share/config/kdeglobals. \
Thus, lot of user settings are lost (font, style, colors, default Web Browser, ...).
Opening backgroundrc (line 306) with KConfig::SimpleConfig OpenFlag (like for kdmrc \
at line 285) fixes this issue. This fix was proposed by Pulfer in bugreport \
254430#c16.
regards,
Luc Menut - Mageia
PS: I don't have write access to kde git, so could you commit the change if the \
patch looks fine. Thanks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested with KDE 4.11.2 (Mageia Cauldron)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdm/kcm/main.cpp <span style="color: grey">(8560c89)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113493/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic