[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 102391: Don't hang when determining MIME type of corrupted files
From:       "Peter Penz" <peter.penz19 () gmail ! com>
Date:       2013-10-27 19:02:19
Message-ID: 20131027190219.27630.48266 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102391/
-----------------------------------------------------------

(Updated Oct. 27, 2013, 7:02 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Bugs: 280446
    http://bugs.kde.org/show_bug.cgi?id=280446


Repository: kdelibs


Description
-------

If KMimeTypeRepository::findFromContent() tries to determine MIME from a file that \
cannot be read, such as on a corrupted optical disc, a read attempt is made in \
KMimeMagicMatch::match() for every available rule, resulting in UI hangs (e.g. file \
dialogs, dolphin) for tens of minutes (see \
https://bugs.kde.org/show_bug.cgi?id=280446 for more details).

I've submitted this patch here on behalf of Miroslav ?os, who has submitted the \
bug-report and also has written the patch.


Diffs
-----

  kdecore/services/kmimetype.cpp 955bf62 
  kdecore/services/kmimetyperepository.cpp 6ff3d16 

Diff: http://git.reviewboard.kde.org/r/102391/diff/


Testing
-------


Thanks,

Peter Penz


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102391/">http://git.reviewboard.kde.org/r/102391/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Peter Penz.</div>


<p style="color: grey;"><i>Updated Oct. 27, 2013, 7:02 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=280446">280446</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If KMimeTypeRepository::findFromContent() tries to determine MIME from a \
file that cannot be read, such as on a corrupted optical disc, a read attempt is made \
in KMimeMagicMatch::match() for every available rule, resulting in UI hangs (e.g. \
file dialogs, dolphin) for tens of minutes (see \
https://bugs.kde.org/show_bug.cgi?id=280446 for more details).

I&#39;ve submitted this patch here on behalf of Miroslav ?os, who has submitted the \
bug-report and also has written the patch.

</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/services/kmimetype.cpp <span style="color: grey">(955bf62)</span></li>

 <li>kdecore/services/kmimetyperepository.cpp <span style="color: \
grey">(6ff3d16)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102391/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic