[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113447: Attempt to unbreak pre-configuring QML applets via desktop scripting, tak
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-10-27 12:20:06
Message-ID: 20131027122006.18200.35457 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113447/#review42433
-----------------------------------------------------------
Ship it!
this is also a pretty bad hack because it will cause all usages of this on files that \
*should* be merged to exhibit strange behaviour. however, that is not how it is used \
in libplasma, so having this hack is preferable to having broken config updates.
for KF5, this points to how kconfig needs work -> it should be possible to retrieve \
the OpenFlags that were used to create it; reparse should *not* cause a sync() just \
to re-read values from disk, values on disk that have changed should override the \
values set in the config object and life should continue on as expected. that a \
*read* action causes a *write* is completely unexpected from an application API POV.
- Aaron J. Seigo
On Oct. 27, 2013, 12:19 p.m., Eike Hein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113447/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2013, 12:19 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Please see https://git.reviewboard.kde.org/r/113443/ for the earlier attempt and \
> Aaron's review, which lead to this new take.
>
> Diffs
> -----
>
> plasma/configloader.cpp 6e97cb9
>
> Diff: http://git.reviewboard.kde.org/r/113447/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eike Hein
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113447/">http://git.reviewboard.kde.org/r/113447/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is also a pretty \
bad hack because it will cause all usages of this on files that *should* be merged to \
exhibit strange behaviour. however, that is not how it is used in libplasma, so \
having this hack is preferable to having broken config updates.
for KF5, this points to how kconfig needs work -> it should be possible to \
retrieve the OpenFlags that were used to create it; reparse should *not* cause a \
sync() just to re-read values from disk, values on disk that have changed should \
override the values set in the config object and life should continue on as expected. \
that a *read* action causes a *write* is completely unexpected from an application \
API POV.</pre> <br />
<p>- Aaron J. Seigo</p>
<br />
<p>On October 27th, 2013, 12:19 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated Oct. 27, 2013, 12:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Please see https://git.reviewboard.kde.org/r/113443/ for the earlier \
attempt and Aaron's review, which lead to this new take.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/configloader.cpp <span style="color: grey">(6e97cb9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113447/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic