[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2013-10-24 15:08:00
Message-ID: 20131024150800.15682.47884 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113419/#review42286
-----------------------------------------------------------
-1
I have to add some explanation to that.
I'm all OK with plain and simplistic, but not TOO plain and simplistic (aka, the \
Windows 8 and apple route). We don't live in a monochrome age anymore so i think the \
theme should retain "some" subtle color variations. Having said that, the current \
plain horizontal top gradient might be a bit too simple (as in not very stylish) as \
well. Take a look at this for example: \
http://paswall.com/black-wallpaper-6462-hd.html Ignore the texture, but you can see \
the subtle lighting in there. That's probably what the plain theme needs.
This is just my opinion (and i happen to hate iOS7 + windows 8 for their fugly \
themes). I disagree with the change, but understand it if you would push it \
regardless. The general design theme these days seems to be heading back to 16 color \
monitors anyway.
- Mark Gaiser
On Oct. 24, 2013, 2:32 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113419/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 2:32 p.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Removes the white-black gradient spreading through the upper-half of the screen. \
> IMHO it looks more elegant when it's just plain black.
>
> Diffs
> -----
>
> ksplash/ksplashqml/themes/Minimalistic/main.qml e4fb8b8
>
> Diff: http://git.reviewboard.kde.org/r/113419/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Before
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png
> After
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113419/">http://git.reviewboard.kde.org/r/113419/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-1
I have to add some explanation to that.
I'm all OK with plain and simplistic, but not TOO plain and simplistic (aka, the \
Windows 8 and apple route). We don't live in a monochrome age anymore so i think \
the theme should retain "some" subtle color variations. Having said that, \
the current plain horizontal top gradient might be a bit too simple (as in not very \
stylish) as well. Take a look at this for example: \
http://paswall.com/black-wallpaper-6462-hd.html Ignore the texture, but you can see \
the subtle lighting in there. That's probably what the plain theme needs.
This is just my opinion (and i happen to hate iOS7 + windows 8 for their fugly \
themes). I disagree with the change, but understand it if you would push it \
regardless. The general design theme these days seems to be heading back to 16 color \
monitors anyway.</pre> <br />
<p>- Mark Gaiser</p>
<br />
<p>On October 24th, 2013, 2:32 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2013, 2:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removes the white-black gradient spreading through the upper-half of the \
screen. IMHO it looks more elegant when it's just plain black.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksplash/ksplashqml/themes/Minimalistic/main.qml <span style="color: \
grey">(e4fb8b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113419/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png">Before</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png">After</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic