[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113299: KDirWatch code style: braces for one-liner conditionals
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2013-10-21 11:34:09
Message-ID: 20131021113409.12762.80178 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113299/#review42077
-----------------------------------------------------------
I would leave them alone for now. I think we'll revisit the topic of the coding style \
shortly before the split. It might makes sense now to stick purely to the Qt style \
for KF5.
- Kevin Ottens
On Oct. 17, 2013, 4:19 a.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113299/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 4:19 a.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> KDirWatch code style: braces for one-liner conditionals
>
> Added braces around single-line bodies of conditionals and loops,
> as specified in the kdelibs coding style.
> --end of commit message--
>
> As in my previous review about whitespace, I appreciate any feedback; if I added \
> braces where the code looked better without or viceversa, or if I should push this \
> to master too, or if I should leave the damn braces alone and discard the review :) \
> In some simple cases like "if (stuff) return;" I wasn't sure if it was better to \
> leave it without braces...
>
> Diffs
> -----
>
> tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a \
> tier1/kcoreaddons/src/lib/io/kdirwatch_p.h \
> 442d6497b704c179adc13dbb25e450554d31554d
> Diff: http://git.reviewboard.kde.org/r/113299/diff/
>
>
> Testing
> -------
>
> It compiles, tests pass.
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113299/">http://git.reviewboard.kde.org/r/113299/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would leave them alone \
for now. I think we'll revisit the topic of the coding style shortly before the \
split. It might makes sense now to stick purely to the Qt style for KF5.</pre> <br \
/>
<p>- Kevin Ottens</p>
<br />
<p>On October 17th, 2013, 4:19 a.m. UTC, Nicolás Alvarez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2013, 4:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDirWatch code style: braces for one-liner conditionals
Added braces around single-line bodies of conditionals and loops,
as specified in the kdelibs coding style.
--end of commit message--
As in my previous review about whitespace, I appreciate any feedback; if I added \
braces where the code looked better without or viceversa, or if I should push this to \
master too, or if I should leave the damn braces alone and discard the review :) In \
some simple cases like "if (stuff) return;" I wasn't sure if it was \
better to leave it without braces...</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles, tests pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <span style="color: \
grey">(e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch_p.h <span style="color: \
grey">(442d6497b704c179adc13dbb25e450554d31554d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113299/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic