From kde-core-devel Thu Oct 17 04:19:17 2013 From: =?utf-8?q?Nicol=C3=A1s_Alvarez?= Date: Thu, 17 Oct 2013 04:19:17 +0000 To: kde-core-devel Subject: Review Request 113299: KDirWatch code style: braces for one-liner conditionals Message-Id: <20131017041917.24925.21329 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138198358022692 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6195840372462807580==" --===============6195840372462807580== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/ ----------------------------------------------------------- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description ------- KDirWatch code style: braces for one-liner conditionals Added braces around single-line bodies of conditionals and loops, as specified in the kdelibs coding style. --end of commit message-- As in my previous review about whitespace, I appreciate any feedback; if I added braces where the code looked better without or viceversa, or if I should push this to master too, or if I should leave the damn braces alone and discard the review :) In some simple cases like "if (stuff) return;" I wasn't sure if it was better to leave it without braces... Diffs ----- tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113299/diff/ Testing ------- It compiles, tests pass. Thanks, Nicolás Alvarez --===============6195840372462807580== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/

Review request for KDE Frameworks and kdelibs.

By Nicolás Alvarez.

Repository: kdelibs

Description

KDirWatch code style: braces for one-liner conditionals

Added braces around single-line bodies of conditionals and loops,
as specified in the kdelibs coding style.
--end of commit message--

As in my previous review about whitespace, I appreciate any feedback; if I added braces where the code looked better without or viceversa, or if I should push this to master too, or if I should leave the damn braces alone and discard the review :) In some simple cases like "if (stuff) return;" I wasn't sure if it was better to leave it without braces...

Testing

It compiles, tests pass.

Diffs

tier1/kcoreaddons/src/lib/io/kdirwatch.cpp (e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a)
tier1/kcoreaddons/src/lib/io/kdirwatch_p.h (442d6497b704c179adc13dbb25e450554d31554d)

--===============6195840372462807580==--