[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113298: KDirWatch code style: cleanup whitespace.
From: Nicolás_Alvarez <nicolas.alvarez () gmail ! com>
Date: 2013-10-17 3:51:18
Message-ID: 20131017035118.21428.15985 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/
-----------------------------------------------------------
(Updated Oct. 17, 2013, 12:51 a.m.)
Review request for KDE Frameworks and kdelibs.
Repository: kdelibs
Description (updated)
-------
KDirWatch code style: cleanup whitespace.
The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and \
alignment, including a few tabs(!). This is a full cleanup of it.
I appreciate any feedback; if I "fixed" something that didn't need fixing, or if you \
see more whitespace errors that I didn't fix, or if I should push this to master too, \
or if I should leave the damn thing alone and discard the review :)
This file is also lacking braces for single-line conditionals and loops; I'll fix \
that in a separate commit for easier reviewing. It's also mixing 2-space and 4-space \
indentations, but changing everything to 4 spaces (as the kdelibs coding style says) \
seemed too intrusive. Perhaps I should change the few 4-space indentations into \
2-space for consistency?
Diffs
-----
tier1/kcoreaddons/src/lib/io/kdirwatch.h 7f6ca8ce83426c81a6336514c247aa9d115ec59e
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a \
tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d \
Diff: http://git.reviewboard.kde.org/r/113298/diff/
Testing
-------
Still compiles :)
Thanks,
Nicolás Alvarez
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113298/">http://git.reviewboard.kde.org/r/113298/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Nicolás Alvarez.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2013, 12:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDirWatch code style: cleanup whitespace.
The KDirWatch code had *lots* of "( foo )" and inconsistent indentation and \
alignment, including a few tabs(!). This is a full cleanup of it.
I appreciate any feedback; if I "fixed" something that didn't need \
fixing, or if you see more whitespace errors that I didn't fix, or if I should \
push this to master too, or if I should leave the damn thing alone and discard the \
review :)
This file is also lacking braces for single-line conditionals and loops; I'll fix \
that in a separate commit for easier reviewing. It's also mixing 2-space and \
4-space indentations, but changing everything to 4 spaces (as the kdelibs coding \
style says) seemed too intrusive. Perhaps I should change the few 4-space \
indentations into 2-space for consistency?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still compiles :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.h <span style="color: \
grey">(7f6ca8ce83426c81a6336514c247aa9d115ec59e)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <span style="color: \
grey">(e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a)</span></li>
<li>tier1/kcoreaddons/src/lib/io/kdirwatch_p.h <span style="color: \
grey">(442d6497b704c179adc13dbb25e450554d31554d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113298/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic