--===============6586105155863286488== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41772 ----------------------------------------------------------- This review has been submitted with commit 1816bac51326767236b0c6402e9db5a8651d98f0 by Mark Gaiser to branch frameworks. - Commit Hook On Oct. 14, 2013, 12:46 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113205/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 12:46 p.m.) > > > Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens. > > > Repository: kdelibs > > > Description > ------- > > The new signal/slot connection: > connect(job, &KJob::result,... > > does't like result to be private and throws an compile error: > error: 'void KJob::result(KJob*)' is private > > Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public. > > > Diffs > ----- > > tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 > tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f > > Diff: http://git.reviewboard.kde.org/r/113205/diff/ > > > Testing > ------- > > Works just fine. > > > Thanks, > > Mark Gaiser > > --===============6586105155863286488== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/ 

This review has been submitted with commit 1816bac51326767236b0c6402e9db5a8651d98f0 by Mark Gaiser to branch frameworks.

- Commit Hook


On October 14th, 2013, 12:46 p.m. UTC, Mark Gaiser wrote:

Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.
By Mark Gaiser.

Updated Oct. 14, 2013, 12:46 p.m.

Repository: kdelibs

Description 

The new signal/slot connection:
connect(job, &KJob::result,...

does't like result to be private and throws an compile error:
error: 'void KJob::result(KJob*)' is private

Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public.

Testing 

Works just fine.

Diffs

  • tier1/kcoreaddons/src/lib/jobs/kjob.h (d663530)
  • tier1/kcoreaddons/src/lib/jobs/kjob.cpp (f99a99f)

View Diff
--===============6586105155863286488==--