[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 113185: Cursor Theme KCM: Show correct resize cursor in preview for themes withou
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2013-10-13 16:18:36
Message-ID: 20131013161836.19346.46952 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113185/
-----------------------------------------------------------
(Updated Oct. 13, 2013, 4:18 p.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace, kwin, Fredrik Höglund, and Thomas \
Lübking.
Bugs: 325837
http://bugs.kde.org/show_bug.cgi?id=325837
Repository: kde-workspace
Description
-------
Apparently in XCursorTheme::findAlternative() (file \
kcontrol/input/xcursor/xcursortheme.cpp) the alternatives for "size_bdiag" \
and "size_fdiag" are swapped, so for themes not containing "size_fdiag" the \
wrong resize cursor is shown in the preview.
This patch fixes that long standing bug. (there has been no change to that \
function since 2007!)
This also fixes the glitch mentioned in bug#325763, that the wrong arrows \
are used for the window resize hint after the theme change is applied (for \
the current X session).
Diffs
-----
kcontrol/input/xcursor/xcursortheme.cpp 010c9ad
Diff: http://git.reviewboard.kde.org/r/113185/diff/
Testing
-------
- Enter systemsettings->Workspace Appearance->Cursor Theme
- Select a theme without "size_fdiag", f.e.: crystalwhite, DMZ, Adwaita
- Look at the preview: without the patch, the wrong resize cursor is shown, \
with the patch it's the same as for Oxygen e.g. See atached screenshots
File Attachments
----------------
KCM without the patch
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/9cb9ae8c-6614-49ea-aae2-fdbeb36dd71e__cursor.png
KCM with the patch
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/f3cf8c6d-d2a0-4e96-8f77-75a53f66395f__cursor2.png
Thanks,
Wolfgang Bauer
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113185/">http://git.reviewboard.kde.org/r/113185/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kde-workspace, kwin, Fredrik Höglund, and Thomas \
Lübking.</div> <div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Oct. 13, 2013, 4:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325837">325837</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Apparently in XCursorTheme::findAlternative() (file \
kcontrol/input/xcursor/xcursortheme.cpp) the alternatives for \
"size_bdiag" and "size_fdiag" are swapped, so for \
themes not containing "size_fdiag" the wrong resize cursor is \
shown in the preview.
This patch fixes that long standing bug. (there has been no change to that \
function since 2007!)
This also fixes the glitch mentioned in bug#325763, that the wrong arrows \
are used for the window resize hint after the theme change is applied (for \
the current X session).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Enter systemsettings->Workspace Appearance->Cursor \
Theme
- Select a theme without "size_fdiag", f.e.: crystalwhite, DMZ, \
Adwaita
- Look at the preview: without the patch, the wrong resize cursor is shown, \
with the patch it's the same as for Oxygen e.g. See atached \
screenshots</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/input/xcursor/xcursortheme.cpp <span style="color: \
grey">(010c9ad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113185/diff/" \
style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/9cb9ae8c-6614-49ea-aae2-fdbeb36dd71e__cursor.png">KCM \
without the patch</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/10/f3cf8c6d-d2a0-4e96-8f77-75a53f66395f__cursor2.png">KCM \
with the patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic