[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113218: Enable translation functions for js script loaded through Kross
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-10-12 15:30:00
Message-ID: 20131012153000.25858.15660 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113218/#review41593
-----------------------------------------------------------
Makes sense to me, personally i'd like someone else to give a ship it, but if noone \
does in some time, just ping me and i'll do :D
- Albert Astals Cid
On Oct. 12, 2013, 3:09 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113218/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2013, 3:09 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Bit of background: Account Wizard in kmail uses few js/es scripts (QScriptEngine) \
> which are loaded using Kross. They expose one string each (but there could \
> potentially more strings) which are visibile in the user interface but not \
> translated. See for example:
> https://projects.kde.org/projects/kde/kdepim-runtime/repository/revisions/master/entry/resources/imap/wizard/imapwizard.es#L24
>
> QScriptEngine supports functions using functions like qsTr:
> http://qt-project.org/doc/qt-4.8/scripting.html#internationalization
> but the engine should be initialized, otherwise they are not recognized. The patch \
> addresses this problem.
> I think this is a bugfix which should go into Platform 4.11.
>
> Frameworks: currently Kross uses QScriptEngine, so this should be easily merged \
> there (I didn't try). If QScriptEngine is replace by QJSEngine, this issue should \
> be addressed as well; a brief check in the documentation does not show any \
> installTranslatorFunctions() method, but maybe the translation functions are now \
> always exposed in the JS engine.
>
> Diffs
> -----
>
> kross/qts/script.cpp 41d46b2
> kross/qts/main.cpp 041c306
>
> Diff: http://git.reviewboard.kde.org/r/113218/diff/
>
>
> Testing
> -------
>
> It compiles, and qsTr is recognized when loading the scripts in kmail.
>
>
> Thanks,
>
> Luigi Toscano
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113218/">http://git.reviewboard.kde.org/r/113218/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense to me, \
personally i'd like someone else to give a ship it, but if noone does in some \
time, just ping me and i'll do :D</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On October 12th, 2013, 3:09 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2013, 3:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bit of background: Account Wizard in kmail uses few js/es scripts \
(QScriptEngine) which are loaded using Kross. They expose one string each (but there \
could potentially more strings) which are visibile in the user interface but not \
translated. See for example:
https://projects.kde.org/projects/kde/kdepim-runtime/repository/revisions/master/entry/resources/imap/wizard/imapwizard.es#L24
QScriptEngine supports functions using functions like qsTr:
http://qt-project.org/doc/qt-4.8/scripting.html#internationalization
but the engine should be initialized, otherwise they are not recognized. The patch \
addresses this problem.
I think this is a bugfix which should go into Platform 4.11.
Frameworks: currently Kross uses QScriptEngine, so this should be easily merged there \
(I didn't try). If QScriptEngine is replace by QJSEngine, this issue should be \
addressed as well; a brief check in the documentation does not show any \
installTranslatorFunctions() method, but maybe the translation functions are now \
always exposed in the JS engine. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles, and qsTr is recognized when loading the scripts in \
kmail.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kross/qts/script.cpp <span style="color: grey">(41d46b2)</span></li>
<li>kross/qts/main.cpp <span style="color: grey">(041c306)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113218/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic