From kde-core-devel Sat Oct 12 12:06:09 2013 From: "Jaime Torres Amate" Date: Sat, 12 Oct 2013 12:06:09 +0000 To: kde-core-devel Subject: Review Request 113216: some little performance improvement for network kio Message-Id: <20131012120609.24397.71530 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138157959307830 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7549751374250339313==" --===============7549751374250339313== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/ ----------------------------------------------------------- Review request for KDE Runtime. Repository: kde-runtime Description ------- A new check by cppcheck (avoid to call the copy constructor). networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() return const QString&. Diffs ----- kioslave/network/ioslave/networkslave.cpp a548f1a Diff: http://git.reviewboard.kde.org/r/113216/diff/ Testing ------- Thanks, Jaime Torres Amate --===============7549751374250339313== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113216/

Review request for KDE Runtime.

By Jaime Torres Amate.

Repository: kde-runtime

Description

A new check by cppcheck (avoid to call the copy constructor).
networkUri.serviceName() and networkUri.serviceType() and networkUri.hostAddress() return const QString&.

Diffs

kioslave/network/ioslave/networkslave.cpp (a548f1a)

View Diff

--===============7549751374250339313==--