[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath t
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-10-10 12:28:07
Message-ID: 20131010122807.15299.34522 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 10, 2013, 10:16 a.m., Albert Astals Cid wrote:
> > Was this commited?
> > Also isn't a whole remove in the middle a bit too dangerous?
>
> Ömer Fadıl Usta wrote:
> I had also some suspicions so i delayed commiting for check it on different \
> installed paths on the other hand i forget to commit. so it didn't committed but i \
> need to check it again before committing it. maybe we need to discard this review \
> request until i had time to check it again and confirm if that bug still exists
the patch is obviously incorrect. the real question is why the plugin name is \
duplicated, and that can only be because of a limited number of reasons: the package \
defaultRoot includes the package name (which it shouldn't), KStandardDirs (which \
should not be used, but the qt5 replacement for it) is returning something wrong \
(which is very unlikely here) or something is going wrong in PackageStructure. but \
removing the plugin name is not the right answer, it just works around a symptom.
I'll discard this review.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110118/#review41480
-----------------------------------------------------------
On April 21, 2013, 6:18 p.m., Ömer Fadıl Usta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110118/
> -----------------------------------------------------------
>
> (Updated April 21, 2013, 6:18 p.m.)
>
>
> Review request for kde-workspace, Aaron J. Seigo and Marco Martin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: \
> "/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" \
> invalid, basePath is ""
> it resets basePath due to double pluginname at the end of path.
>
>
> Diffs
> -----
>
> plasma/desktop/shell/activitymanager/activitymanager.cpp 2ecb30d
>
> Diff: http://git.reviewboard.kde.org/r/110118/diff/
>
>
> Testing
> -------
>
> After this patch that warning about invalid path is gone. I have checked that \
> package->path() returning correct address now.
>
> Thanks,
>
> Ömer Fadıl Usta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110118/">http://git.reviewboard.kde.org/r/110118/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 10th, 2013, 10:16 a.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Was this commited? Also isn't a whole remove in the middle a bit too \
dangerous?</pre> </blockquote>
<p>On October 10th, 2013, 12:20 p.m. UTC, <b>Ömer Fadıl Usta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I had also some \
suspicions so i delayed commiting for check it on different installed paths on the \
other hand i forget to commit. so it didn't committed but i need to check it \
again before committing it. maybe we need to discard this review request until i had \
time to check it again and confirm if that bug still exists</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the patch is obviously \
incorrect. the real question is why the plugin name is duplicated, and that can only \
be because of a limited number of reasons: the package defaultRoot includes the \
package name (which it shouldn't), KStandardDirs (which should not be used, but \
the qt5 replacement for it) is returning something wrong (which is very unlikely \
here) or something is going wrong in PackageStructure. but removing the plugin name \
is not the right answer, it just works around a symptom.
I'll discard this review.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On April 21st, 2013, 6:18 p.m. UTC, Ömer Fadıl Usta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Aaron J. Seigo and Marco Martin.</div>
<div>By Ömer Fadıl Usta.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 6:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: \
"/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" \
invalid, basePath is ""
it resets basePath due to double pluginname at the end of path.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After this patch that warning about invalid path is gone. I have checked \
that package->path() returning correct address now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/activitymanager/activitymanager.cpp <span style="color: \
grey">(2ecb30d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110118/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic