[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112880: Added KColorSchemeToken class.
From: "Denis Kuplyakov" <dener.kup () gmail ! com>
Date: 2013-10-09 11:42:34
Message-ID: 20131009114234.20038.37971 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
> > kdeui/colors/kcolorschemetoken.h, line 70
> > <http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70>
> >
> > using int here loses the type-safety. Why no use the corresponding enums? It \
> > would also make the code more readable.
> > (Same issue for all the other methods.)
>
> Denis Kuplyakov wrote:
> I have tried it, but have such errors:
> Error: Unknown method parameter type: QPalette::ColorGroup
>
> See this: http://qt-project.org/forums/viewthread/10308/ . It seems that the int is \
> only way to make it works correct.
> Sebastian Kügler wrote:
> Have you tried registering that enum using qmlRegisterType?
Yes, I have, but 0 is always go to function. Have you read the link above, such \
behaviour was described there.
- Denis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41068
-----------------------------------------------------------
On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2013, 7:24 p.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them \
> accessible from QML code.
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to \
> libkdegames, as it uses it to access KDE's color theme.
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames \
> mailinglists *
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt b439e04
> includes/CMakeLists.txt cdf0143
> includes/KColorSchemeToken PRE-CREATION
> kdeui/colors/kcolorscheme.h 17570fd
> kdeui/colors/kcolorscheme.cpp a6650ac
> kdeui/colors/kcolorschemetoken.h PRE-CREATION
> kdeui/colors/kcolorschemetoken.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
>
>
> Testing
> -------
>
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
>
>
> Thanks,
>
> Denis Kuplyakov
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112880/">http://git.reviewboard.kde.org/r/112880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 1st, 2013, 2:47 p.m. UTC, <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112880/diff/6/?file=192050#file192050line70" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/colors/kcolorschemetoken.h</a> <span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_INVOKABLE</span> <span class="k">static</span> <span \
class="n">QColor</span> <span class="nf">background</span><span \
class="p">(</span><span class="kt">int</span> <span class="n">colorGroup</span><span \
class="p">,</span> <span class="kt">int</span> <span class="n">colorSet</span><span \
class="p">,</span> <span class="kt">int</span> <span \
class="n">backgroundRole</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">using int here loses the \
type-safety. Why no use the corresponding enums? It would also make the code more \
readable.
(Same issue for all the other methods.)</pre>
</blockquote>
<p>On October 6th, 2013, 7:10 p.m. UTC, <b>Denis Kuplyakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tried it, but \
have such errors:
Error: Unknown method parameter type: QPalette::ColorGroup
See this: http://qt-project.org/forums/viewthread/10308/ . It seems that the int is \
only way to make it works correct.</pre> </blockquote>
<p>On October 8th, 2013, 8:35 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you tried \
registering that enum using qmlRegisterType?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I \
have, but 0 is always go to function. Have you read the link above, such behaviour \
was described there.</pre> <br />
<p>- Denis</p>
<br />
<p>On October 6th, 2013, 7:24 p.m. UTC, Denis Kuplyakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2013, 7:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It is wrapper to access KColorScheme's methods from QML code. Also \
added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from \
QML code.
As it will be accepted, QML-clone of KgPopupItem will be posted for review to \
libkdegames, as it uses it to access KDE's color theme.
More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames \
mailinglists *</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've tested it with KReversi's deniskup/gsoc2013/newdesign \
branch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(b439e04)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(cdf0143)</span></li>
<li>includes/KColorSchemeToken <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/colors/kcolorscheme.h <span style="color: grey">(17570fd)</span></li>
<li>kdeui/colors/kcolorscheme.cpp <span style="color: grey">(a6650ac)</span></li>
<li>kdeui/colors/kcolorschemetoken.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kdeui/colors/kcolorschemetoken.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112880/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic