[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113175: Always use an external viewer application to view files
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2013-10-08 17:55:37
Message-ID: 20131008175537.12123.57182 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 8, 2013, 4:47 p.m., Jonathan Marten wrote:
> > I'm not totally happy with this change. Yes, the internal viewer is limited in \
> > functionality, but it has advantages: (1) it is fast to open and can be closed \
> > again with a single keystroke; (2) it remembers its size and can be resized \
> > without affecting the default window size of, say, KWrite or whichever external \
> > application is used; (3) it can be forced to display an archive component of any \
> > type as plain text.
> > There's nothing wrong with having the facility to open an archive component in \
> > its default application (or any other application), but it should be an option. \
> > Either a configuration setting (Use internal viewer - Use external application), \
> > or a context menu with options View (in the internal viewer), Open (in the \
> > default application) or Open With... (any other application).
>
> Sven Brauch wrote:
> I guessed some people would not be happy with it, but it was worth a try ;)
>
> How about a context menu action? Or, since the context menu is currently empty, \
> just opening the external viewer on right-click?
Not sure that changing the function of the right-click would be approved of (but \
then, I'm not the ark maintainer or authority, just an intensive user of it). Maybe \
the middle button?
There has been some discussion about adding a context menu to Ark before now - e.g. \
bug #166203.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113175/#review41400
-----------------------------------------------------------
On Oct. 8, 2013, 3:23 p.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113175/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 3:23 p.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Repository: ark
>
>
> Description
> -------
>
> This patch makes ark always use an external viewer application instead of using the \
> clunky internal preview thing. The internal viewer would just embed a plain kpart \
> into a window, but without providing any of the XMLGUI or whatever from that part. \
> Thus, when you for example clicked a PDF, you couldn't print it. The advantages of \
> the internal viewer are imo overall quite questionable, and are far outweighted by \
> its disadvantages.
> Plus, it removes code ;)
>
>
> Diffs
> -----
>
> part/CMakeLists.txt 9e384438b60322f1d51d31e40c556b2912970ceb
> part/arkviewer.h bb41472eaec985e2e1b3d9c2f7c257c949316bf4
> part/arkviewer.cpp 053cd1c0502d3bb88895dc8d3653eaea9e6c3c83
> part/part.cpp b4ebcd27c462d2b8037b5ea40c56969eda71bdcb
>
> Diff: http://git.reviewboard.kde.org/r/113175/diff/
>
>
> Testing
> -------
>
> Clicking files opens them in the default application, as it should.
>
>
> Thanks,
>
> Sven Brauch
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113175/">http://git.reviewboard.kde.org/r/113175/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 8th, 2013, 4:47 p.m. UTC, <b>Jonathan \
Marten</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not totally happy with this change. Yes, the internal viewer is \
limited in functionality, but it has advantages: (1) it is fast to open and can be \
closed again with a single keystroke; (2) it remembers its size and can be resized \
without affecting the default window size of, say, KWrite or whichever external \
application is used; (3) it can be forced to display an archive component of any \
type as plain text.
There's nothing wrong with having the facility to open an archive component in \
its default application (or any other application), but it should be an option. \
Either a configuration setting (Use internal viewer - Use external application), or a \
context menu with options View (in the internal viewer), Open (in the default \
application) or Open With... (any other application).</pre> </blockquote>
<p>On October 8th, 2013, 4:59 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guessed some people \
would not be happy with it, but it was worth a try ;)
How about a context menu action? Or, since the context menu is currently empty, just \
opening the external viewer on right-click?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure that changing \
the function of the right-click would be approved of (but then, I'm not the ark \
maintainer or authority, just an intensive user of it). Maybe the middle button?
There has been some discussion about adding a context menu to Ark before now - e.g. \
bug #166203. </pre>
<br />
<p>- Jonathan</p>
<br />
<p>On October 8th, 2013, 3:23 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 3:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes ark always use an external viewer application instead \
of using the clunky internal preview thing. The internal viewer would just embed a \
plain kpart into a window, but without providing any of the XMLGUI or whatever from \
that part. Thus, when you for example clicked a PDF, you couldn't print it. The \
advantages of the internal viewer are imo overall quite questionable, and are far \
outweighted by its disadvantages.
Plus, it removes code ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Clicking files opens them in the default application, as it \
should.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/CMakeLists.txt <span style="color: \
grey">(9e384438b60322f1d51d31e40c556b2912970ceb)</span></li>
<li>part/arkviewer.h <span style="color: \
grey">(bb41472eaec985e2e1b3d9c2f7c257c949316bf4)</span></li>
<li>part/arkviewer.cpp <span style="color: \
grey">(053cd1c0502d3bb88895dc8d3653eaea9e6c3c83)</span></li>
<li>part/part.cpp <span style="color: \
grey">(b4ebcd27c462d2b8037b5ea40c56969eda71bdcb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113175/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic