On October 7th, 2013, 9:35 a.m. UTC, Stephen Kelly wrote:

src/plasma/CMakeLists.txt (Diff revision 1)
		173	if(IS_ABSOLUTE "${INCLUDE_INSTALL_DIR}")

The if-else shouldn't be needed. INSTALL_INTERFACE should already check if ${INCLUDE_INSTALL_DIR} is absolute.

On October 7th, 2013, 9:36 a.m. UTC, Ben Cooksley wrote:

I copied this code from KCoreAddons in kdelibs[frameworks]. Shall I correct it there as well?

On October 7th, 2013, 11:50 a.m. UTC, Stephen Kelly wrote:

It appears in several other frameworks too. Actually your snippet is needed until CMake 2.8.12. I'll remove it from them all when kde requires that version.

Okay. I removed the IS_ABSOLUTE part when I committed though, so that might need to be adjusted back in then.

- Ben

On October 7th, 2013, 10:48 a.m. UTC, Ben Cooksley wrote:

Add include targets for KF5::plasma, which will hopefully contribute towards fixing the kde-workspace[master] build on build.kde.org.
Unfortunately it isn't entirely successful as it seems camelcase headers are installed by KF5::plasma into include/KDE/Plasma/ but it should be a start...

In place on CI build system. Proper include path now given to compiler.