[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2013-10-07 17:42:51
Message-ID: 20131007174251.6035.58844 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113127/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 5:42 p.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace, Plasma and Marco Martin.
Bugs: 325330
http://bugs.kde.org/show_bug.cgi?id=325330
Repository: kde-workspace
Description
-------
Don't register the icon as a draggable with the applet.
This causes events to be intercepted which prevents launching the file manager when
the applet is movable.
The same has been done for the icon plasmoid some time ago:
http://commits.kde.org/kde-workspace/2a685d9a1d87d11680970cea88cdcc96da17d514
Diffs
-----
plasma/desktop/applets/trash/trash.cpp d8007c0
Diff: http://git.reviewboard.kde.org/r/113127/diff/
Testing
-------
- Add a trash plasmoid to the desktop, make sure widgets are unlocked.
- Click on the trash
- file manager gets started every time, without the patch nothing happens (most of the time).
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113127/">http://git.reviewboard.kde.org/r/113127/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Marco Martin.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2013, 5:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325330">325330</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Don't register the icon as a draggable with the applet.
This causes events to be intercepted which prevents launching the file manager when
the applet is movable.
The same has been done for the icon plasmoid some time ago:
http://commits.kde.org/kde-workspace/2a685d9a1d87d11680970cea88cdcc96da17d514</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Add a trash plasmoid to the desktop, make sure widgets \
are unlocked.
- Click on the trash
- file manager gets started every time, without the patch nothing happens (most of \
the time).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/trash/trash.cpp <span style="color: \
grey">(d8007c0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113127/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic