[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()
From: Martin Bříza <mbriza () redhat ! com>
Date: 2013-10-07 16:06:16
Message-ID: 20131007160616.20706.50159 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113152/
-----------------------------------------------------------
Review request for kde-workspace.
Repository: kde-workspace
Description
-------
Using the date selector in kcm_clock to set any date further than February 7, 2106 \
resulted in setting the time to ((time_t) (unsigned int) -1). This patch makes \
setting any date further than this to spit out an DateError. Also, it's a seed for \
discussion regarding this KCM module as passing the values as QStrings and converting \
from/to time_t doesn't seem like a manageable solution to the problem. Thanks for \
your opinions.
Diffs
-----
kcontrol/dateandtime/dtime.cpp 518afe5
kcontrol/dateandtime/helper.cpp 9168db3
Diff: http://git.reviewboard.kde.org/r/113152/diff/
Testing
-------
Built and tested on Fedora 19 x86_64.
Thanks,
Martin Bříza
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113152/">http://git.reviewboard.kde.org/r/113152/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Martin Bříza.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using the date selector in kcm_clock to set any date further than \
February 7, 2106 resulted in setting the time to ((time_t) (unsigned int) -1). This \
patch makes setting any date further than this to spit out an DateError. Also, \
it's a seed for discussion regarding this KCM module as passing the values as \
QStrings and converting from/to time_t doesn't seem like a manageable solution to \
the problem. Thanks for your opinions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built and tested on Fedora 19 x86_64.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/dateandtime/dtime.cpp <span style="color: grey">(518afe5)</span></li>
<li>kcontrol/dateandtime/helper.cpp <span style="color: grey">(9168db3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113152/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic