[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation
From:       "Bruno Farias" <brunocarvalhofarias () gmail ! com>
Date:       2013-10-04 18:37:07
Message-ID: 20131004183707.9638.9939 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112848/
-----------------------------------------------------------

(Updated Oct. 4, 2013, 2:37 p.m.)


Review request for kdelibs.


Changes
-------

fixing coding style as indicated


Repository: kdelibs


Description
-------

- Adding new test for kbuttongroup
- Fixing kbuttongroup.cpp identation


Diffs (updated)
-----

  kdeui/tests/kbuttongrouptest.h cd9130a9b0840160bdce5a1841735e2050d10a7d 
  kdeui/tests/kbuttongrouptest.cpp d5f9f88b839d4be88cac81c1e7d0444422dd17ea 
  kdeui/widgets/kbuttongroup.h de813ea95dca1247698537a966abe474fa9650cf 
  kdeui/widgets/kbuttongroup.cpp 4057cc023107cd76cc34590f4b1dd91e01717d3d 

Diff: http://git.reviewboard.kde.org/r/112848/diff/


Testing
-------

All tests of KButtonGroupTest were passed


Thanks,

Bruno Farias


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112848/">http://git.reviewboard.kde.org/r/112848/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bruno Farias.</div>


<p style="color: grey;"><i>Updated Oct. 4, 2013, 2:37 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixing coding style as indicated</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- Adding new test for kbuttongroup
- Fixing kbuttongroup.cpp identation</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests of KButtonGroupTest were passed</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/tests/kbuttongrouptest.h <span style="color: \
grey">(cd9130a9b0840160bdce5a1841735e2050d10a7d)</span></li>

 <li>kdeui/tests/kbuttongrouptest.cpp <span style="color: \
grey">(d5f9f88b839d4be88cac81c1e7d0444422dd17ea)</span></li>

 <li>kdeui/widgets/kbuttongroup.h <span style="color: \
grey">(de813ea95dca1247698537a966abe474fa9650cf)</span></li>

 <li>kdeui/widgets/kbuttongroup.cpp <span style="color: \
grey">(4057cc023107cd76cc34590f4b1dd91e01717d3d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112848/diff/" \
style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic