[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-09-27 14:10:54
Message-ID: 20130927141054.23091.77478 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112848/#review40908
-----------------------------------------------------------
Not a thorough review, but some comments inline anyway.
kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30051>
no spaces around the parentheses
kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30052>
If you're doing formatting changes, please submit them in a separate patch.
It's not so much of an issue here, but makes it easier to review.
kdeui/widgets/kbuttongroup.cpp
<http://git.reviewboard.kde.org/r/112848/#comment30053>
no spaces within parentheses:
if (event->removed()) {
- Sebastian Kügler
On Sept. 20, 2013, 7:23 p.m., Bruno Farias wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112848/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2013, 7:23 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> - Adding new test for kbuttongroup
> - Fixing kbuttongroup.cpp identation
>
>
> Diffs
> -----
>
> kdeui/tests/kbuttongrouptest.h cd9130a9b0840160bdce5a1841735e2050d10a7d
> kdeui/tests/kbuttongrouptest.cpp d5f9f88b839d4be88cac81c1e7d0444422dd17ea
> kdeui/widgets/kbuttongroup.cpp 4057cc023107cd76cc34590f4b1dd91e01717d3d
>
> Diff: http://git.reviewboard.kde.org/r/112848/diff/
>
>
> Testing
> -------
>
> All tests of KButtonGroupTest were passed
>
>
> Thanks,
>
> Bruno Farias
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112848/">http://git.reviewboard.kde.org/r/112848/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not a thorough review, \
but some comments inline anyway.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112848/diff/1/?file=190963#file190963line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/widgets/kbuttongroup.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">36</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span> <span class="o">&</span><span \
class="n">clickedMapper</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span class="n">mapped</span><span \
class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span \
class="n">q</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">slotClicked</span><span class="p">(</span><span \
class="kt">int</span><span class="p">))</span> <span class="p">);</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">41</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span> <span class="o">&</span><span \
class="n">clickedMapper</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span class="n">mapped</span><span \
class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span \
class="n">q</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">slotClicked</span><span class="p">(</span><span \
class="kt">int</span><span class="p">))</span> <span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no spaces \
around the parentheses</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112848/diff/1/?file=190963#file190963line72" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/widgets/kbuttongroup.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KButtonGroup::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">66</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span> <span class="o">!</span><span \
class="n">testAttribute</span><span class="p">(</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">WA_WState_Polished</span> <span class="p">)</span> \
<span class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">71</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span> <span class="o">!</span><span class="n">testAttribute</span><span \
class="p">(</span> <span class="n">Qt</span><span class="o">::</span><span \
class="n">WA_WState_Polished</span> <span class="p">)</span> <span \
class="p">)</span><span class="hl"> </span><span class="p"><span \
class="hl">{</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If \
you're doing formatting changes, please submit them in a separate patch.
It's not so much of an issue here, but makes it easier to review.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112848/diff/1/?file=190963#file190963line127" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/widgets/kbuttongroup.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KButtonGroup::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">124</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span \
class="p">(</span> <span class="n">event</span><span class="o">-></span><span \
class="n">removed</span><span class="p">()</span> <span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no spaces \
within parentheses:
if (event->removed()) {
</pre>
</div>
<br />
<p>- Sebastian</p>
<br />
<p>On September 20th, 2013, 7:23 p.m. UTC, Bruno Farias wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bruno Farias.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2013, 7:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Adding new test for kbuttongroup
- Fixing kbuttongroup.cpp identation</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests of KButtonGroupTest were passed</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/tests/kbuttongrouptest.h <span style="color: \
grey">(cd9130a9b0840160bdce5a1841735e2050d10a7d)</span></li>
<li>kdeui/tests/kbuttongrouptest.cpp <span style="color: \
grey">(d5f9f88b839d4be88cac81c1e7d0444422dd17ea)</span></li>
<li>kdeui/widgets/kbuttongroup.cpp <span style="color: \
grey">(4057cc023107cd76cc34590f4b1dd91e01717d3d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112848/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic