'Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo
From:       "Commit Hook" <null () kde ! org>
Date:       2013-09-25 11:56:14
Message-ID: 20130925115614.20937.76912 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112816/
-----------------------------------------------------------

(Updated Sept. 25, 2013, 11:56 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kdelibs.


Description
-------

This is a two-commit patch:

1. Add a KColorUtils::getHcy() method

2. In kcolorutils demo: use KColorUtils::getHcy() instead of the internal KColorSpaces::KHCY

This is a required first step to make kconfigwidgets build standalone


Diffs
-----

  staging/kconfigwidgets/tests/kcolorutilsdemo.cpp 940569e 
  tier1/kguiaddons/src/lib/colors/kcolorutils.h c20c6f7 
  tier1/kguiaddons/src/lib/colors/kcolorutils.cpp 9212bba 

Diff: http://git.reviewboard.kde.org/r/112816/diff/


Testing
-------

kcolorutilsdemo still works.


Thanks,

Aurélien Gâteau


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112816/">http://git.reviewboard.kde.org/r/112816/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Aurélien Gâteau.</div>


<p style="color: grey;"><i>Updated Sept. 25, 2013, 11:56 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a two-commit patch:

1. Add a KColorUtils::getHcy() method

2. In kcolorutils demo: use KColorUtils::getHcy() instead of the internal \
KColorSpaces::KHCY

This is a required first step to make kconfigwidgets build standalone


</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kcolorutilsdemo still works.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>staging/kconfigwidgets/tests/kcolorutilsdemo.cpp <span style="color: \
grey">(940569e)</span></li>

 <li>tier1/kguiaddons/src/lib/colors/kcolorutils.h <span style="color: \
grey">(c20c6f7)</span></li>

 <li>tier1/kguiaddons/src/lib/colors/kcolorutils.cpp <span style="color: \
grey">(9212bba)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112816/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic