[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 112880: Added KColorSchemeToken class.
From: "Denis Kuplyakov" <dener.kup () gmail ! com>
Date: 2013-09-22 10:16:07
Message-ID: 20130922101607.23309.52088 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
It is wrapper to access KColorScheme's methods from QML code.
Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML \
code.
As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as \
it uses it to access KDE's color theme.
More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
NEED TO FIX:
I can't include it like #include <KColorSchemeToken> at KReversi's code, only \
"kcolorschemetoken.h". Maybe I've missed something?
Diffs
-----
kdeui/CMakeLists.txt b439e04
kdeui/colors/kcolorscheme.h 17570fd
kdeui/colors/kcolorscheme.cpp a6650ac
kdeui/colors/kcolorschemetoken.h PRE-CREATION
kdeui/colors/kcolorschemetoken.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112880/diff/
Testing
-------
Thanks,
Denis Kuplyakov
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112880/">http://git.reviewboard.kde.org/r/112880/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Denis Kuplyakov.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is wrapper to \
access KColorScheme's methods from QML code. Also added Q_GADGET to KColorScheme to enable \
Q_ENUMS using, to make them accessible from QML code.
As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as \
it uses it to access KDE's color theme.
More info:
* search for "KDE theme colors API for QML" thread at kdelibs and kdegames \
mailinglists *
NEED TO FIX:
I can't include it like #include <KColorSchemeToken> at KReversi's code, only \
"kcolorschemetoken.h". Maybe I've missed something?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(b439e04)</span></li>
<li>kdeui/colors/kcolorscheme.h <span style="color: grey">(17570fd)</span></li>
<li>kdeui/colors/kcolorscheme.cpp <span style="color: grey">(a6650ac)</span></li>
<li>kdeui/colors/kcolorschemetoken.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/colors/kcolorschemetoken.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112880/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic