[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112241: Fix "Show Launcher when not running" option in taskbar widget
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2013-08-24 15:32:16
Message-ID: 20130824153216.1186.67524 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 24, 2013, 3:17 p.m., Eike Hein wrote:
> > Hm, on the face of it, this patch doesn't really make sense ... launcher items \
> > don't have an associated task, so the function should already return early and \
> > the extra condition should be redundant. Unless there's a race condition in the \
> > library somewhere ... but then it still wouldn't crash on translating a QPoint.
> > Thank you for the patch, but I really still have to find a way to reproduce this \
> > bug before just applying this blindly - it might be treating a symptom instead of \
> > addressing the root cause.
>
> Bhushan Shah wrote:
> Are you sure that this happens on 32 bit only?
>
> Eike Hein wrote:
> No, I'm not - except I can't reproduce it on any of my 64 bit machines, and I have \
> to assume if it were a widespread bug, the number of reports we'd be getting would \
> be much, much higher. Note that we didn't even get any reports through any of the \
> pre-releases about this, AFAIR.
> I'm typing this from a cellphone right now, but I hope when I get home tonight I'll \
> finally get around to setting up a 32 bit VM, and I'm hoping it'll crash there so I \
> can throw all the gdb/valgrind/asan at it we got :).
> Thomas Lübking wrote:
> What bug and is "WId" involved?
https://bugs.kde.org/show_bug.cgi?id=322283
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112241/#review38481
-----------------------------------------------------------
On Aug. 24, 2013, 2 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112241/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 2 p.m.)
>
>
> Review request for kde-workspace, Plasma and Eike Hein.
>
>
> Description
> -------
>
> Fix the crash in plasma-desktop caused by newer QML taskbar widget.
>
> Simple steps to reproduce this crash.
>
> 1) Pin any task/application to taskbar using "show launcher when not running" \
> option. 2) Close application.
> 3) Desktop crashes.
>
> Reason :
>
> 1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three \
> conditions,
> -> pointer to task is not null
> -> taskItem itself is not null
> -> scene is not null
>
> 2) This condition gets false when item is LauncherItem. In function later line 334 \
> when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
> Patch :
>
> This patch adds check in if condition to check if taskItem is \
> TaskManager::LauncherItemType and return from function if this is launcher item.
>
> Diffs
> -----
>
> plasma/desktop/applets/tasks/tasks.cpp c4aef4b
>
> Diff: http://git.reviewboard.kde.org/r/112241/diff/
>
>
> Testing
> -------
>
> Testing
>
> compilation - check
> installation - check
> plasmoidviewer - check
> in panel - check
> independently - check
>
>
> Thanks,
>
> Bhushan Shah
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112241/">http://git.reviewboard.kde.org/r/112241/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 24th, 2013, 3:17 p.m. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hm, on the face of it, this patch doesn't really make sense ... \
launcher items don't have an associated task, so the function should already \
return early and the extra condition should be redundant. Unless there's a race \
condition in the library somewhere ... but then it still wouldn't crash on \
translating a QPoint.
Thank you for the patch, but I really still have to find a way to reproduce this bug \
before just applying this blindly - it might be treating a symptom instead of \
addressing the root cause.</pre> </blockquote>
<p>On August 24th, 2013, 3:22 p.m. UTC, <b>Bhushan Shah</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you sure that this \
happens on 32 bit only?</pre> </blockquote>
<p>On August 24th, 2013, 3:28 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, I'm not - except \
I can't reproduce it on any of my 64 bit machines, and I have to assume if it \
were a widespread bug, the number of reports we'd be getting would be much, much \
higher. Note that we didn't even get any reports through any of the pre-releases \
about this, AFAIR.
I'm typing this from a cellphone right now, but I hope when I get home tonight \
I'll finally get around to setting up a 32 bit VM, and I'm hoping it'll \
crash there so I can throw all the gdb/valgrind/asan at it we got :).</pre> \
</blockquote>
<p>On August 24th, 2013, 3:30 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What bug and is \
"WId" involved?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">https://bugs.kde.org/show_bug.cgi?id=322283</pre> <br />
<p>- Bhushan</p>
<br />
<p>On August 24th, 2013, 2 p.m. UTC, Bhushan Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Eike Hein.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2013, 2 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix the crash in plasma-desktop caused by newer QML taskbar widget.
Simple steps to reproduce this crash.
1) Pin any task/application to taskbar using "show launcher when not \
running" option. 2) Close application.
3) Desktop crashes.
Reason :
1) In Tasks::itemGeometryChanged(int,int,int,int,int) line 300 it checks for three \
conditions,
-> pointer to task is not null
-> taskItem itself is not null
-> scene is not null
2) This condition gets false when item is LauncherItem. In function later line 334 \
when calling iconRect.moveTopLeft(QPoint) function it gets crashed.
Patch :
This patch adds check in if condition to check if taskItem is \
TaskManager::LauncherItemType and return from function if this is launcher \
item.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing
compilation - check
installation - check
plasmoidviewer - check
in panel - check
independently - check</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/tasks.cpp <span style="color: \
grey">(c4aef4b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112241/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic