'Re: Review Request 112223: Enable FileBrowser DataEngine'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 112223: Enable FileBrowser DataEngine
From:       "Commit Hook" <null () kde ! org>
Date:       2013-08-23 13:05:40
Message-ID: 20130823130540.20042.93428 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112223/#review38435
-----------------------------------------------------------


This review has been submitted with commit 82b3692a6854c61c89dce500e84593363ed8a9e1 \
by Bhushan Shah to branch frameworks-scratch.

- Commit Hook


On Aug. 23, 2013, 12:56 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112223/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 12:56 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Description
> -------
> 
> Enable FileBrowser DataEngine on top of KF5
> 
> 
> Diffs
> -----
> 
> plasma/generic/dataengines/CMakeLists.txt 579e929 
> plasma/generic/dataengines/filebrowser/CMakeLists.txt 528414f 
> plasma/generic/dataengines/filebrowser/filebrowserengine.h 49819a9 
> plasma/generic/dataengines/filebrowser/filebrowserengine.cpp 2387bee 
> 
> Diff: http://git.reviewboard.kde.org/r/112223/diff/
> 
> 
> Testing
> -------
> 
> Compiles = check
> Plasma Engine explorer = Check
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112223/">http://git.reviewboard.kde.org/r/112223/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 82b3692a6854c61c89dce500e84593363ed8a9e1 by Bhushan Shah to \
branch frameworks-scratch.</pre>  <br />









<p>- Commit</p>


<br />
<p>On August 23rd, 2013, 12:56 p.m. UTC, Bhushan Shah wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace and Plasma.</div>
<div>By Bhushan Shah.</div>


<p style="color: grey;"><i>Updated Aug. 23, 2013, 12:56 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Enable FileBrowser DataEngine on top of KF5</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles = check Plasma Engine explorer = Check</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/CMakeLists.txt <span style="color: \
grey">(579e929)</span></li>

 <li>plasma/generic/dataengines/filebrowser/CMakeLists.txt <span style="color: \
grey">(528414f)</span></li>

 <li>plasma/generic/dataengines/filebrowser/filebrowserengine.h <span style="color: \
grey">(49819a9)</span></li>

 <li>plasma/generic/dataengines/filebrowser/filebrowserengine.cpp <span style="color: \
grey">(2387bee)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112223/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic