[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.
From: "Commit Hook" <null () kde ! org>
Date: 2013-08-21 16:50:34
Message-ID: 20130821165034.6595.48218 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112128/
-----------------------------------------------------------
(Updated Aug. 21, 2013, 4:50 p.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian \
Kügler.
Description
-------
Currently uninstallation of plasma themes is very broken for a couple of reasons. One \
reason is that the tar packages downloaded from kde-look and other kns services \
contain a subfolder with the theme name, that then contains the metadata.desktop file \
that plasma::PackageStructure looks for in order to uninstall or install a plugin. \
The other problem is that themes aren't really plugins, so plasmapkg -t theme -r blah \
fails. This patch fixes the second issue. I'll upload another patch for review that \
fixes the first issue.
Diffs
-----
plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46
Diff: http://git.reviewboard.kde.org/r/112128/diff/
Testing
-------
Plasma themes correctly uninstall here with this and my other patch.
Thanks,
Jeremy Paul Whiting
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112128/">http://git.reviewboard.kde.org/r/112128/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and \
Sebastian Kügler.</div> <div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2013, 4:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently uninstallation of plasma themes is very broken for a couple of \
reasons. One reason is that the tar packages downloaded from kde-look and other kns \
services contain a subfolder with the theme name, that then contains the \
metadata.desktop file that plasma::PackageStructure looks for in order to uninstall \
or install a plugin. The other problem is that themes aren't really plugins, so \
plasmapkg -t theme -r blah fails. This patch fixes the second issue. I'll upload \
another patch for review that fixes the first issue.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plasma themes correctly uninstall here with this and my other \
patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/tools/plasmapkg/main.cpp <span style="color: \
grey">(6a2982b292ec9736710f4b41dcaa0cbff3986c46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112128/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic