'Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex
From:       "Michael Bohlender" <michael.bohlender () kdemail ! net>
Date:       2013-08-17 16:25:20
Message-ID: 20130817162520.5750.60648 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111953/#review38038
-----------------------------------------------------------

Ship it!


sorry for taking so long. I applied the patch and everything worked. nice script btw.

- Michael Bohlender


On Aug. 14, 2013, 7:30 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111953/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 7:30 a.m.)
> 
> 
> Review request for kdelibs, Michael Bohlender and Stephen Kelly.
> 
> 
> Description
> -------
> 
> In addition to synchronizing selection, make KLinkItemSelectionModel also \
> synchronize the current index. 
> This fixes a bug in Gwenview where image operations are not applied to the correct \
> images when multiple images are selected. 
> 
> This addresses bug 322850.
> http://bugs.kde.org/show_bug.cgi?id=322850
> 
> 
> Diffs
> -----
> 
> kdeui/itemviews/klinkitemselectionmodel.h 392da46 
> kdeui/itemviews/klinkitemselectionmodel.cpp ee55d4f 
> kdeui/tests/klinkitemselectionmodeltest.h f3e0fd1 
> kdeui/tests/klinkitemselectionmodeltest.cpp c3f7132 
> 
> Diff: http://git.reviewboard.kde.org/r/111953/diff/
> 
> 
> Testing
> -------
> 
> - Extended unit-tests to test the current index is synchronized.
> - Verified the bug is fixed in Gwenview.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111953/">http://git.reviewboard.kde.org/r/111953/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry for taking so \
long. I applied the patch and everything worked. nice script btw.</pre>  <br />









<p>- Michael</p>


<br />
<p>On August 14th, 2013, 7:30 a.m. UTC, Aurélien Gâteau wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Michael Bohlender and Stephen Kelly.</div>
<div>By Aurélien Gâteau.</div>


<p style="color: grey;"><i>Updated Aug. 14, 2013, 7:30 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In addition to synchronizing selection, make KLinkItemSelectionModel \
also synchronize the current index.

This fixes a bug in Gwenview where image operations are not applied to the correct \
images when multiple images are selected.


</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- Extended unit-tests to test the current index is \
                synchronized.
- Verified the bug is fixed in Gwenview.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=322850">322850</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/itemviews/klinkitemselectionmodel.h <span style="color: \
grey">(392da46)</span></li>

 <li>kdeui/itemviews/klinkitemselectionmodel.cpp <span style="color: \
grey">(ee55d4f)</span></li>

 <li>kdeui/tests/klinkitemselectionmodeltest.h <span style="color: \
grey">(f3e0fd1)</span></li>

 <li>kdeui/tests/klinkitemselectionmodeltest.cpp <span style="color: \
grey">(c3f7132)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111953/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic