[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only sub
From: "Marco Martin" <notmart () gmail ! com>
Date: 2013-08-17 8:26:15
Message-ID: 20130817082615.1679.17531 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/#review38015
-----------------------------------------------------------
Hmm, not sure about it, the packages were defined as archives with metadata.desktop \
in the root, this would basically allow a quirks mode, do we want to support \
malformed packages?
- Marco Martin
On Aug. 17, 2013, 3:06 a.m., Jeremy Paul Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112129/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 3:06 a.m.)
>
>
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and \
> Sebastian Kügler.
>
> Description
> -------
>
> This is the other half of the fix for the listed bug. I made \
> Plasma::PackageStructure::metadata look in the only subdirectory of an extracted \
> archive if there's only one subdirectory for the metadata.desktop file.
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=149479.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479
>
>
> Diffs
> -----
>
> plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b
>
> Diff: http://git.reviewboard.kde.org/r/112129/diff/
>
>
> Testing
> -------
>
> The bug is fixed here with this and my other patch. Any better ideas for getting \
> the only subdirectory are welcome, it feels a bit kludgy as is.
>
> Thanks,
>
> Jeremy Paul Whiting
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112129/">http://git.reviewboard.kde.org/r/112129/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, not sure about it, \
the packages were defined as archives with metadata.desktop in the root, this would \
basically allow a quirks mode, do we want to support malformed packages?</pre> <br \
/>
<p>- Marco</p>
<br />
<p>On August 17th, 2013, 3:06 a.m. UTC, Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and \
Sebastian Kügler.</div> <div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 3:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the other half of the fix for the listed bug. I made \
Plasma::PackageStructure::metadata look in the only subdirectory of an extracted \
archive if there's only one subdirectory for the metadata.desktop file.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The bug is fixed here with this and my other patch. Any better ideas for \
getting the only subdirectory are welcome, it feels a bit kludgy as is.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479">https://bugs.kde.org/show_bug.cgi?id=149479</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/packagestructure.cpp <span style="color: \
grey">(71148e1a18227d9ca847cbffe385aaaad9c66c6b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112129/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic