[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2013-08-04 14:35:20
Message-ID: 1695206.fpEndYUgl3 () xps
[Download RAW message or body]

El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure:
> On Sunday 04 August 2013 00:28:17 Milian Wolff wrote:
> > Hey all,
> > 
> > I'd like to backport this comment from kdelibs master to KDE 4.11, is this
> > OK?
> 
> Ahum, sorry - accidentally hit "ctrl + enter".
> 
> commit 0bd9529fc3d9382dc748a2f7f5306903c674151c
> Author: Milian Wolff <mail@milianw.de>
> Date:   Sun Jul 21 21:07:36 2013 +0200
> 
>     Add basic support for clang in FindKDE4Internal.cmake.
> 
> This is the commit I'm talking about. Any objections?

I don't see a huge problem with it with my release team hat, I'd still prefer 
you wait for someone more in the know of the area to ACK the backport.

Cheers,
  Albert

> 
> Generally, what's the way to go with these changes? Should I have pushed it
> to KDE/4.11 initially and then that gets merged into master by someone?
> 
> Bye

[prev in list] [next in list] [prev in thread] [next in thread]