[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat cal
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2013-08-03 23:34:18
Message-ID: 20130803233418.14370.57846 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote:
> > kdecore/io/kdirwatch.cpp, line 327
> > <http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line327>
> >
> > why did you move that outside? is this being used elsewhere? if so, I can't see \
> > it by the diff apparently.
Well, no. it's not being used outside, but that exact line was created in three if \
statements and i moved it up one level. That seemed cleaner to me, i guess i can move \
it back if you want to. Do note that there are only 4 if statements there so only one \
case where the line wouldn't be created otherwise.
> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote:
> > kdecore/io/kdirwatch.cpp, line 372
> > <http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line372>
> >
> > the indentation is broken here, no? should be two spaces like the rest of the \
> > file.
Actually, the kdirwatch.cpp file is broken in it's entirety when it comes to \
indentation. I followed the kdelibs coding style (4 spaces) and kdirwatch is using a \
mixture of 2 and 4 spaces. Do you suggest that i use the "mixed" indentation style \
for this patch to match the file or the kdelibs style?
> On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote:
> > kdecore/io/kdirwatch.cpp, line 545
> > <http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line545>
> >
> > isDir looks like an outparam but is used like an in-param here. will this work \
> > for all cases where this function is being called when inotify is present?
Yes, this works for all cases with inotify.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111870/#review37041
-----------------------------------------------------------
On Aug. 3, 2013, 9:28 p.m., Mark Gaiser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111870/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2013, 9:28 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> At first i wasn't intending to even ask a reviewrequest for this because i want to \
> fix an issue that is well described in my thread: "KDirWatch bug and the analysis. \
> Help is welcome!" on kde-core-devel. However, while starting on fixing that issue i \
> noticed that this would be a nice small improvement to have. It also prevents one \
> stat call that was used to determine if "entry" was a file or folder, but inotify \
> already gives us that information.
>
> Diffs
> -----
>
> kdecore/io/kdirwatch.cpp 95ee3d3
>
> Diff: http://git.reviewboard.kde.org/r/111870/diff/
>
>
> Testing
> -------
>
> Compiles just fine.
> Runs fine, i haven't seen any issues thus far.
> Oh and it passes all kio test cases but i specially note the following:
> kdirwatchtest
> kdirlistertest
> kdirmodeltest
>
>
> Thanks,
>
> Mark Gaiser
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111870/">http://git.reviewboard.kde.org/r/111870/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 3rd, 2013, 10:27 p.m. UTC, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line327" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdecore/io/kdirwatch.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KDirWatchPrivate::inotifyEventReceived()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">327</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">const</span> <span class="n">QString</span> <span \
class="n">tpath</span> <span class="o">=</span> <span class="n">e</span><span \
class="o">-></span><span class="n">path</span> <span class="o">+</span> <span \
class="n">QLatin1Char</span><span class="p">(</span><span \
class="sc">'/'</span><span class="p">)</span> <span class="o">+</span> <span \
class="n">path</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why did you move that \
outside? is this being used elsewhere? if so, I can't see it by the diff \
apparently.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, no. \
it's not being used outside, but that exact line was created in three if \
statements and i moved it up one level. That seemed cleaner to me, i guess i can move \
it back if you want to. Do note that there are only 4 if statements there so only one \
case where the line wouldn't be created otherwise.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 3rd, 2013, 10:27 p.m. UTC, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line372" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdecore/io/kdirwatch.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KDirWatchPrivate::inotifyEventReceived()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">371</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">const</span> <span class="n">QList</span><span \
class="o"><</span><span class="n">Client</span> <span class="o">*></span> <span \
class="n">clients</span> <span class="o">=</span> <span class="n">e</span><span \
class="o">-></span><span class="n">clientsForFileOrDir</span><span \
class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span \
class="o">&</span><span class="n">isDir</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the indentation is \
broken here, no? should be two spaces like the rest of the file.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, \
the kdirwatch.cpp file is broken in it's entirety when it comes to indentation. I \
followed the kdelibs coding style (4 spaces) and kdirwatch is using a mixture of 2 \
and 4 spaces. Do you suggest that i use the "mixed" indentation style for \
this patch to match the file or the kdelibs style?</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 3rd, 2013, 10:27 p.m. UTC, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line545" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdecore/io/kdirwatch.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString KDirWatchPrivate::Entry::parentDirectory() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">537</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="n">KDirWatch</span><span class="o">::</span><span \
class="n">WatchModes</span> <span class="n">flag</span> <span class="o">=</span> \
<span class="o">*</span><span class="n">isDir</span> <span class="o">?</span> <span \
class="n">KDirWatch</span><span class="o">::</span><span \
class="n">WatchSubDirs</span> <span class="o">:</span> <span \
class="n">KDirWatch</span><span class="o">::</span><span \
class="n">WatchFiles</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">isDir looks like an \
outparam but is used like an in-param here. will this work for all cases where this \
function is being called when inotify is present?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, this \
works for all cases with inotify.</pre> <br />
<p>- Mark</p>
<br />
<p>On August 3rd, 2013, 9:28 p.m. UTC, Mark Gaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Mark Gaiser.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2013, 9:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">At first i wasn't intending to even ask a reviewrequest for this \
because i want to fix an issue that is well described in my thread: "KDirWatch \
bug and the analysis. Help is welcome!" on kde-core-devel. However, while \
starting on fixing that issue i noticed that this would be a nice small improvement \
to have. It also prevents one stat call that was used to determine if \
"entry" was a file or folder, but inotify already gives us that \
information.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles just fine. Runs fine, i haven't seen any issues thus far.
Oh and it passes all kio test cases but i specially note the following:
kdirwatchtest
kdirlistertest
kdirmodeltest</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/kdirwatch.cpp <span style="color: grey">(95ee3d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111870/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic