[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2013-08-03 21:28:42
Message-ID: 20130803212842.26628.89095 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111870/
-----------------------------------------------------------
Review request for kdelibs and David Faure.
Description
-------
At first i wasn't intending to even ask a reviewrequest for this because i want to \
fix an issue that is well described in my thread: "KDirWatch bug and the analysis. \
Help is welcome!" on kde-core-devel. However, while starting on fixing that issue i \
noticed that this would be a nice small improvement to have. It also prevents one \
stat call that was used to determine if "entry" was a file or folder, but inotify \
already gives us that information.
Diffs
-----
kdecore/io/kdirwatch.cpp 95ee3d3
Diff: http://git.reviewboard.kde.org/r/111870/diff/
Testing
-------
Compiles just fine.
Runs fine, i haven't seen any issues thus far.
Oh and it passes all kio test cases but i specially note the following:
kdirwatchtest
kdirlistertest
kdirmodeltest
Thanks,
Mark Gaiser
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111870/">http://git.reviewboard.kde.org/r/111870/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Mark Gaiser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">At first i wasn't intending to even ask a reviewrequest for this \
because i want to fix an issue that is well described in my thread: "KDirWatch \
bug and the analysis. Help is welcome!" on kde-core-devel. However, while \
starting on fixing that issue i noticed that this would be a nice small improvement \
to have. It also prevents one stat call that was used to determine if \
"entry" was a file or folder, but inotify already gives us that \
information.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles just fine. Runs fine, i haven't seen any issues thus far.
Oh and it passes all kio test cases but i specially note the following:
kdirwatchtest
kdirlistertest
kdirmodeltest</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/kdirwatch.cpp <span style="color: grey">(95ee3d3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111870/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic