[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Broken tests in kdelibs due to kio change
From: Dawit A <adawit () kde ! org>
Date: 2013-08-03 21:14:01
Message-ID: CALa28R4xBt37ZxEc9a36GQnLCZFovvVKv7AtkRq=kHHJhU58kA () mail ! gmail ! com
[Download RAW message or body]
Well I do not consider this to be a new dependency, runtime or otherwise
since KIO already has a dependency on QtGui in the current stable branches.
In frameworks that is going to be changed such that the core and ui
portions will be separated out into their own components. Anyhow, my
question was really limited to the effects this patch might have on the
work being done in frameworks only.
The breakage of the unit tests arise from the fact that these unit tests
were attempting not to create an instance of QApplication in their main
function because they did not test portion of KIO that relied on it. They
still link against QtGui however. Of course that changed with the use of
QClipboard in some of the KIO functions and hence broke the unit tests. I
will fix the kde-runtime tests as well.
On Sat, Aug 3, 2013 at 1:52 PM, Albert Astals Cid <aacid@kde.org> wrote:
> El Dissabte, 3 d'agost de 2013, a les 13:39:40, Dawit A va escriure:
> > OK. I see why those tests failed and I fixed them not to anymore.
> Updating
> > the clibpboard in KIO introduced a dependency on QtGui.
> > Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed
> > to QTEST_KDEMAIN( KDirModelTest, GUI ).
> >
> > Hmm... I am curious if the dependency on QClipboard makes it difficult to
> > split this into core/gui in frameworks?
>
> I am not a KIO specialist, is this new runtime dependency ok that late in
> the
> release cycle?
>
> Can anyone more in the know [than me] comment?
>
> If it is, it seems some kde-runtime tests also have to be fixed.
>
> http://build.kde.org/view/KDE%20SC%20stable/job/kde-runtime_stable/291/
>
> Cheers,
> Albert
>
> >
> > On Sat, Aug 3, 2013 at 1:16 PM, Dawit A <adawit@kde.org> wrote:
> > > Hmm... I fail to see how my changes break those unit tests. Perhaps
> > > changing fileundomanager from NoGui to Gui did it? Anyhow, I will try
> to
> > > look into it.
> > >
> > > On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <aacid@kde.org>
> wrote:
> > >> Dawit, kdelibs people, there are 4 tests that broke in
> > >> very-close-to-release
> > >> 4.11 branch with a change from yesterday to kio.
> > >>
> > >> http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/
> > >>
> > >> Can you guys please have a look and fix those failing tests?
> > >>
> > >> Also please please please make sure you either run the tests before
> > >> commiting
> > >> changes so late in the release cycle *and* even if you run them please
> > >> check
> > >> with jenkins to see his opinion on your changes :)
> > >>
> > >> Cheers,
> > >>
> > >> Albert
>
>
[Attachment #3 (text/html)]
<div dir="ltr">Well I do not consider this to be a new dependency, runtime \
or otherwise since KIO already has a dependency on QtGui in the current \
stable branches. In frameworks that is going to be changed such that the \
core and ui portions will be separated out into their own components. \
Anyhow, my question was really limited to the effects this patch might have \
on the work being done in frameworks only.<div>
<div><br></div><div>The breakage of the unit tests arise from the fact that \
these unit tests were attempting not to create an instance of QApplication \
in their main function because they did not test portion of KIO that relied \
on it. They still link against QtGui however. Of course that changed with \
the use of QClipboard in some of the KIO functions and hence broke the unit \
tests. I will fix the kde-runtime tests as well.</div>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On \
Sat, Aug 3, 2013 at 1:52 PM, Albert Astals Cid <span dir="ltr"><<a \
href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">El Dissabte, 3 d'agost de 2013, a les \
13:39:40, Dawit A va escriure:<br> <div class="im">> OK. I see why those \
tests failed and I fixed them not to anymore. Updating<br> > the \
clibpboard in KIO introduced a dependency on QtGui.<br> > Hence \
QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed<br> > to \
QTEST_KDEMAIN( KDirModelTest, GUI ).<br> ><br>
> Hmm... I am curious if the dependency on QClipboard makes it difficult \
to<br> > split this into core/gui in frameworks?<br>
<br>
</div>I am not a KIO specialist, is this new runtime dependency ok that \
late in the<br> release cycle?<br>
<br>
Can anyone more in the know [than me] comment?<br>
<br>
If it is, it seems some kde-runtime tests also have to be fixed.<br>
<br>
<a href="http://build.kde.org/view/KDE%20SC%20stable/job/kde-runtime_stable/291/" \
target="_blank">http://build.kde.org/view/KDE%20SC%20stable/job/kde-runtime_stable/291/</a><br>
<br>
Cheers,<br>
Albert<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> On Sat, Aug 3, 2013 at 1:16 PM, Dawit A <<a \
href="mailto:adawit@kde.org">adawit@kde.org</a>> wrote:<br> > > \
Hmm... I fail to see how my changes break those unit tests. Perhaps<br> \
> > changing fileundomanager from NoGui to Gui did it? Anyhow, I will \
try to<br> > > look into it.<br>
> ><br>
> > On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <<a \
href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br> > >> \
Dawit, kdelibs people, there are 4 tests that broke in<br> > >> \
very-close-to-release<br> > >> 4.11 branch with a change from \
yesterday to kio.<br> > >><br>
> >> <a href="http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/" \
target="_blank">http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/</a><br>
> >><br>
> >> Can you guys please have a look and fix those failing \
tests?<br> > >><br>
> >> Also please please please make sure you either run the tests \
before<br> > >> commiting<br>
> >> changes so late in the release cycle *and* even if you run \
them please<br> > >> check<br>
> >> with jenkins to see his opinion on your changes :)<br>
> >><br>
> >> Cheers,<br>
> >><br>
> >> Albert<br>
<br>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic