--089e013a215accedf404e30e9198
Content-Type: text/plain; charset=UTF-8

OK. I see why those tests failed and I fixed them not to anymore. Updating
the clibpboard in KIO introduced a dependency on QtGui.
Hence QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed
to QTEST_KDEMAIN( KDirModelTest, GUI ).

Hmm... I am curious if the dependency on QClipboard makes it difficult to
split this into core/gui in frameworks?


On Sat, Aug 3, 2013 at 1:16 PM, Dawit A <adawit@kde.org> wrote:

> Hmm... I fail to see how my changes break those unit tests. Perhaps
> changing fileundomanager from NoGui to Gui did it? Anyhow, I will try to
> look into it.
>
>
> On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <aacid@kde.org> wrote:
>
>> Dawit, kdelibs people, there are 4 tests that broke in
>> very-close-to-release
>> 4.11 branch with a change from yesterday to kio.
>>
>> http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/735/
>>
>> Can you guys please have a look and fix those failing tests?
>>
>> Also please please please make sure you either run the tests before
>> commiting
>> changes so late in the release cycle *and* even if you run them please
>> check
>> with jenkins to see his opinion on your changes :)
>>
>> Cheers,
>>   Albert
>>
>
>

--089e013a215accedf404e30e9198
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">OK. I see why those tests failed and I fixed them not to a=
nymore. Updating the clibpboard in KIO introduced a dependency on QtGui. He=
nce=C2=A0QTEST_KDEMAIN( KDirModelTest, NoGUI ) has to be changed to=C2=A0QT=
EST_KDEMAIN( KDirModelTest, GUI ).<div>

<br></div><div style>Hmm... I am curious if the dependency on QClipboard ma=
kes it difficult to split this into core/gui in frameworks?</div></div><div=
 class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Sat, Aug 3, 20=
13 at 1:16 PM, Dawit A <span dir=3D"ltr">&lt;<a href=3D"mailto:adawit@kde.o=
rg" target=3D"_blank">adawit@kde.org</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hmm... I fail to see how my=
 changes break those unit tests. Perhaps changing fileundomanager from NoGu=
i to Gui did it? Anyhow, I will try to look into it.<div>

<div class=3D"h5"><div class=3D"gmail_extra"><br><br><div class=3D"gmail_qu=
ote">

On Sat, Aug 3, 2013 at 10:25 AM, Albert Astals Cid <span dir=3D"ltr">&lt;<a=
 href=3D"mailto:aacid@kde.org" target=3D"_blank">aacid@kde.org</a>&gt;</spa=
n> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;b=
order-left:1px #ccc solid;padding-left:1ex">



Dawit, kdelibs people, there are 4 tests that broke in very-close-to-releas=
e<br>
4.11 branch with a change from yesterday to kio.<br>
<br>
<a href=3D"http://build.kde.org/view/KDE%20SC%20stable/job/kdelibs_stable/7=
35/" target=3D"_blank">http://build.kde.org/view/KDE%20SC%20stable/job/kdel=
ibs_stable/735/</a><br>
<br>
Can you guys please have a look and fix those failing tests?<br>
<br>
Also please please please make sure you either run the tests before commiti=
ng<br>
changes so late in the release cycle *and* even if you run them please chec=
k<br>
with jenkins to see his opinion on your changes :)<br>
<br>
Cheers,<br>
=C2=A0 Albert<br>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>

--089e013a215accedf404e30e9198--