[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: KDirWatch bug and the analysis. Help is welcome!
From:       Milian Wolff <mail () milianw ! de>
Date:       2013-07-31 22:25:33
Message-ID: 2389202.K06hK4mAFp () minime
[Download RAW message or body]

On Wednesday 31 July 2013 20:51:11 Mark wrote:
> Hi,
> 
> I'm horrible in clearly explaining issues and i'm going to explain a
> lot in this mail. Please read it very carefully.

<snip>

> Subsequent signals (even create, delete or anything besides dirty) is
> following this same path where the emit is being triggered from
> KDirWatchPrivate::slotRescan in the above mentioned snippet. All
> signals are thus being send as dirty signals! For more clarity, this
> is what KDirLister(Cache) actually receives (in
> KDirListerCache::slotFileDirty) as signals for the same folder:
> (DIRTY signal) /home/mark/massive_files
> (DIRTY signal) /home/mark/massive_files/.directory.lock
> (DIRTY signal) /home/mark/massive_files/.directorym13357.new
> (DIRTY signal) /home/mark/massive_files (yes, it starts with this and
> ends with this)
> 
> Now i'm guessing this isn't right. All dirty signals of which two(!!)
> are my main folder.

Besides that it's two times that signal, imo this is what should be done. 
Creating/Removing a file makes its parent folder dirty.

Maybe KDirListerCache should not listen on dirty but rather on created and 
deleted instead, which should come with the semantics you describe?

Bye
-- 
Milian Wolff
mail@milianw.de
http://milianw.de
[prev in list] [next in list] [prev in thread] [next in thread]