--===============4379421695922255894== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/ ----------------------------------------------------------- (Updated July 4, 2013, 9:33 p.m.) Status ------ This change has been marked as submitted. Review request for kdelibs. Description ------- Currently, PYTHON_INSTALL macro in PythonMacros.cmake creates same target "compile_python_files" for all Python modules. This somehow works for Make-based builds, but breaks when using Ninja backend for CMake. CMake itself says that it does not guarantee that targets with same name will ever work. The patch creates unique target for each python module being pre-compiled and installed. The patch can be applied without modifications to 4.10 and 4.11, too. Diffs ----- cmake/modules/PythonMacros.cmake 95c9315 Diff: http://git.reviewboard.kde.org/r/111371/diff/ Testing ------- OpenBSD-CURRENT, PyKDE 4.10.4 and 4.10.5. Thanks, Vadim Zhukov --===============4379421695922255894== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111371/

This change has been marked as submitted.

Review request for kdelibs.

By Vadim Zhukov.

Updated July 4, 2013, 9:33 p.m.

Description

Currently, PYTHON_INSTALL macro in PythonMacros.cmake creates same target "compile_python_files" for all Python modules. This somehow works for Make-based builds, but breaks when using Ninja backend for CMake. CMake itself says that it does not guarantee that targets with same name will ever work.

The patch creates unique target for each python module being pre-compiled and installed.

The patch can be applied without modifications to 4.10 and 4.11, too.

Testing

OpenBSD-CURRENT, PyKDE 4.10.4 and 4.10.5.

Diffs

cmake/modules/PythonMacros.cmake (95c9315)

--===============4379421695922255894==--