[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 111370: system_tray: initialize uninitialized members
From:       "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date:       2013-07-03 15:55:24
Message-ID: 20130703155524.3897.47124 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111370/#review35523
-----------------------------------------------------------

Ship it!


Congratulations :P

- Andreas Hartmetz


On July 3, 2013, 3:53 p.m., Jiri Slaby wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111370/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 3:53 p.m.)
> 
> 
> Review request for kde-workspace and Kai Uwe Broulik.
> 
> 
> Description
> -------
> 
> A member in WidgetItem is used unitialized. Fix this.
> 
> See https://bugs.kde.org/show_bug.cgi?id=321828
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/ui/widgetitem.cpp 1f922c921c0f3763e8ffeb4466fbffb527fca2f2 
> 
> Diff: http://git.reviewboard.kde.org/r/111370/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jiri Slaby
> 
>


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111370/">http://git.reviewboard.kde.org/r/111370/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Congratulations :P</pre> \
<br />









<p>- Andreas</p>


<br />
<p>On July 3rd, 2013, 3:53 p.m. UTC, Jiri Slaby wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace and Kai Uwe Broulik.</div>
<div>By Jiri Slaby.</div>


<p style="color: grey;"><i>Updated July 3, 2013, 3:53 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A member in WidgetItem is used unitialized. Fix this.

See https://bugs.kde.org/show_bug.cgi?id=321828</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/systemtray/ui/widgetitem.cpp <span style="color: \
grey">(1f922c921c0f3763e8ffeb4466fbffb527fca2f2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111370/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic