[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11
From: "David Faure" <faure () kde ! org>
Date: 2013-06-15 22:47:41
Message-ID: 20130615224741.19977.5896 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111000/#review34403
-----------------------------------------------------------
Ship it!
Yes, this is fine.
I won't create trouble in KF5 since the whole subdir has been deleted from kdelibs, \
since it will come from the kate.git repo.
interfaces/ktexteditor/messageinterface.h
<http://git.reviewboard.kde.org/r/111000/#comment25273>
Is the '%' on purpose?
interfaces/ktexteditor/messageinterface.h
<http://git.reviewboard.kde.org/r/111000/#comment25272>
extra-qualification will break some compilers. This should just be AutoHideMode, \
no?
- David Faure
On June 15, 2013, 6:18 p.m., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111000/
> -----------------------------------------------------------
>
> (Updated June 15, 2013, 6:18 p.m.)
>
>
> Review request for Kate, kdelibs, Release Team, Christoph Cullmann, and David \
> Faure.
>
> Description
> -------
>
> This patch adds the KTextEditor::MessageInterface to the KTextEditor interfaces in \
> kdelibs 4.11.
> This interface exists in Kate since KDE 4.10, and is already used internally to \
> show messages when needed (e.g. search & replace, or swap file recover bar). By \
> adding this interface to kdelibs, applications like KDevelop, Kile, etc... can use \
> this interface to show passive interactive notifications in a KTextEditor::View.
> With this commit, we also want to get feedback by potential users of this \
> interface, so we can improve/tweak it again for KDE 5 (or whatever it will be \
> called :) ).
>
> Diffs
> -----
>
> interfaces/ktexteditor/messageinterface.cpp PRE-CREATION
> interfaces/ktexteditor/messageinterface.h PRE-CREATION
> interfaces/ktexteditor/CMakeLists.txt 9813734
> includes/KTextEditor/MessageInterface PRE-CREATION
> includes/KTextEditor/Message PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111000/diff/
>
>
> Testing
> -------
>
> Given the interface is in Kate since KDE 4.10, the interface is quite mature.
>
>
> Thanks,
>
> Dominik Haumann
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111000/">http://git.reviewboard.kde.org/r/111000/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, this is fine.
I won't create trouble in KF5 since the whole subdir has been deleted from \
kdelibs, since it will come from the kate.git repo.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111000/diff/1/?file=150260#file150260line164" \
style="color: black; font-weight: bold; text-decoration: \
underline;">interfaces/ktexteditor/messageinterface.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">164</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * displayed in all View%s. If @p closeOnTrigger is @e false, the \
message</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is the \
'%' on purpose?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111000/diff/1/?file=150260#file150260line221" \
style="color: black; font-weight: bold; text-decoration: \
underline;">interfaces/ktexteditor/messageinterface.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">221</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KTextEditor</span><span class="o">::</span><span \
class="n">Message</span><span class="o">::</span><span class="n">AutoHideMode</span> \
<span class="n">autoHideMode</span><span class="p">()</span> <span \
class="k">const</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">extra-qualification will break some compilers. This should just be \
AutoHideMode, no?</pre> </div>
<br />
<p>- David</p>
<br />
<p>On June 15th, 2013, 6:18 p.m. UTC, Dominik Haumann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate, kdelibs, Release Team, Christoph Cullmann, and David \
Faure.</div> <div>By Dominik Haumann.</div>
<p style="color: grey;"><i>Updated June 15, 2013, 6:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the KTextEditor::MessageInterface to the KTextEditor \
interfaces in kdelibs 4.11.
This interface exists in Kate since KDE 4.10, and is already used internally to show \
messages when needed (e.g. search & replace, or swap file recover bar). By adding \
this interface to kdelibs, applications like KDevelop, Kile, etc... can use this \
interface to show passive interactive notifications in a KTextEditor::View.
With this commit, we also want to get feedback by potential users of this interface, \
so we can improve/tweak it again for KDE 5 (or whatever it will be called :) ).</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Given the interface is in Kate since KDE 4.10, the interface is quite \
mature.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/ktexteditor/messageinterface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>interfaces/ktexteditor/messageinterface.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>interfaces/ktexteditor/CMakeLists.txt <span style="color: \
grey">(9813734)</span></li>
<li>includes/KTextEditor/MessageInterface <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>includes/KTextEditor/Message <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111000/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic