[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
From: "Commit Hook" <null () kde ! org>
Date: 2013-05-27 18:14:14
Message-ID: 20130527181414.16553.57390 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review33239
-----------------------------------------------------------
This review has been submitted with commit 73fa526cd5541e74c3e992e9fcb0278efaaa5366 \
by Thomas Lübking to branch KDE/4.10.
- Commit Hook
On March 23, 2013, 8:06 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107983/
> -----------------------------------------------------------
>
> (Updated March 23, 2013, 8:06 p.m.)
>
>
> Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, Martin \
> Gräßlin, and Marco Martin.
>
> Description
> -------
>
> It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with \
> kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17. Didn't \
> try xfce nor mutter.
> Technically:
> I do not at all understand why KWindowSystem is *not* watching the root window - \
> KSelectionOwner for one is sending events to the root and this also seems the case \
> for all other WMs (at least everything now starts to cause the signal to be \
> emitted)
> The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner \
> testcase), there'll be some X11 event processing on top that eats away the client \
> messages. So this one can be scratched from the patch, the KWindowSystem issue \
> remains.
>
> This addresses bug 179042.
> http://bugs.kde.org/show_bug.cgi?id=179042
>
>
> Diffs
> -----
>
> kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
>
> Diff: http://git.reviewboard.kde.org/r/107983/diff/
>
>
> Testing
> -------
>
> see summary
>
>
> File Attachments
> ----------------
>
> testcase
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107983/">http://git.reviewboard.kde.org/r/107983/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 73fa526cd5541e74c3e992e9fcb0278efaaa5366 by Thomas Lübking to \
branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 23rd, 2013, 8:06 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, \
Martin Gräßlin, and Marco Martin.</div> <div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 23, 2013, 8:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works fine here (tested so far KWindowSystem signal, \
KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & \
"metacity -c" and e17. Didn't try xfce nor mutter.
Technically:
I do not at all understand why KWindowSystem is *not* watching the root window - \
KSelectionOwner for one is sending events to the root and this also seems the case \
for all other WMs (at least everything now starts to cause the signal to be emitted)
The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner \
testcase), there'll be some X11 event processing on top that eats away the client \
messages. So this one can be scratched from the patch, the KWindowSystem issue \
remains.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see summary</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=179042">179042</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/kwindowsystem_x11.cpp <span style="color: \
grey">(f9b3cc1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107983/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp">testcase</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic